citizenlab
citizenlab copied to clipboard
[TAN-4791] Move idea custom fields controller out of Admin namespace
Now we are including visitor and regular users in the idea custom_fields index action, (see the very simple BE change in #11347, if interested), it makes little sense to have the controller in the Admin namespace.
Likewise, the admin/ part of the request URL becomes redundant (meaningless/misleading), and thus I've also updated the FE request URLs accordingly.
@jamesspeake Please review the BE changes. Thanks.
@IvaKop Please review the FE changes. Thanks. Note, the e2e tests failing here are only those already failing in the parent branch TAN-4791/survey-form.
Can be based off master if/when TAN-4791/survey-form merged to master
Changelog
- [TAN-4791] Move idea custom fields controller out of Admin namespace
| Messages | |
|---|---|
| :book: | Changelog provided 🎉 |
| :book: | Notion issue: TAN-4791 |
| :book: | |
| :book: | Check translation progress |
Generated by :no_entry_sign: dangerJS against 2b45a41945ac75e99a6d1db85b131f45b797a608
Changes make sense! Please don't forget to run the e2e tests before merging this, just to make sure everything works :)
OK, I'll run them again just before merging 👍
@jinjagit One more thing. Is it possible to merge this, together with your previous PR to master instead of my branch. This will unblock me fixing a bunch of things while we test the survey without it necessarily being merged. Thanks 🙌
Closed in favour of clone #11425, due to weird merge conflicts when I changed base to master