TMPE icon indicating copy to clipboard operation
TMPE copied to clipboard

Published 20 hours ago • verified publisher icon CitiesSkylinesMods

SerializableUIOptionBase should contain value/default-values

Open kianzarrin opened this issue 2 years ago • 3 comments

currently the values are stored in Options.cs and default values are in the legacy code that loads data. We need a central place to store values/default values. it is better to be all in one place. I think we should put them all in SerializableUIOptionBase.

related: #1372 says that all fields of this type should also be moved into one place.

kianzarrin avatar Apr 04 '22 00:04 kianzarrin

@aubergine10 do you agree with this?

kianzarrin avatar Apr 04 '22 20:04 kianzarrin

I think it depends on outcome of discussions in https://github.com/CitiesSkylinesMods/TMPE/issues/1372

originalfoo avatar Apr 04 '22 22:04 originalfoo

Performance wise virtual property call cannot be optimised. Maybe a non virtual getter might not be a bad idea.

kianzarrin avatar Apr 05 '22 06:04 kianzarrin