yang icon indicating copy to clipboard operation
yang copied to clipboard

Conditional imports for gnmi.py not in 23.11 wheel file.

Open miott opened this issue 1 year ago • 3 comments

#110 release 23.11 was created. I assume that a yang.connector-23.11.whl file was supposed to be uploaded to pypi.org. #107 adding some conditional imports was committed 3 weeks prior to #110. Even though the conditional imports are correct in the repository, if I pip install yang.connector==23.11 the conditional imports are not there. It appears the wrong wheel file was uploaded to pypi.org.

miott avatar Dec 20 '23 22:12 miott

Since these are conditional imports, there is no dependency on them and hence the are not required to be installed and thus not added to setup.py.

Please clarify the expected behavior.

dwapstra avatar Dec 21 '23 00:12 dwapstra

Since these are conditional imports, there is no dependency on them and hence the are not required to be installed and thus not added to setup.py.

Please clarify the expected behavior.

Looking closer at the git commit log, It looks like #107 probably did not get merged into master before the 23.11 release wheel was built and uploaded to pypi.org. Screenshot 2023-12-21 at 8 27 01 AM

Since this commit did not get into the wheel, yangsuite fails install inside a pyats 23.11 environment.

When is the next release coming out? If it is not until February, please put out a special release soon. If the next release will be in January, we could just wait.

miott avatar Dec 21 '23 16:12 miott

bumped version: https://github.com/CiscoTestAutomation/yang/pull/115

minor packages released: https://pypi.org/project/yang.ncdiff/23.11.1/#files https://pypi.org/project/yang.connector/23.11.1/#files

domachad avatar Jan 10 '24 19:01 domachad