genieparser icon indicating copy to clipboard operation
genieparser copied to clipboard

Updated source_template parser

Open obrigg opened this issue 2 years ago • 4 comments

Description

A bug is simply a situation we haven't thought of. While parsing a "show run" for an interface, I hit the following line source template 802.1X_PORT_AUTH_TEMPLATE that did not parse the source template attribute. The current parser doesn't handle special characters in the templates' names.

Motivation and Context

Allow the parser to handle special characters in the templates' names.

Impact (If any)

Screenshots:

Checklist:

  • [ ] I have updated the changelog.
  • [ ] I have updated the documentation (If applicable).
  • [ ] I have added tests to cover my changes (If applicable).
  • [ ] All new and existing tests passed.
  • [ ] All new code passed compilation.

obrigg avatar Jun 06 '22 05:06 obrigg

Regex is still a mystery I haven’t solved. I have no doubt my pattern can be improved.

obrigg avatar Jun 13 '22 17:06 obrigg

Can you please add changelog

Sure. You've got it.

obrigg avatar Jun 15 '22 13:06 obrigg

Anything else?

obrigg avatar Jun 26 '22 02:06 obrigg

Anything else?

You haven't provided a folder based unit test that covers this change

domachad avatar Jun 27 '22 13:06 domachad