genielibs icon indicating copy to clipboard operation
genielibs copied to clipboard

XR Clean InstallImagesAndPackages improvement

Open Tristou27 opened this issue 3 years ago • 2 comments

Hello,

This small change in the XR Clean InstallImagesAndPackages should ease the error detection for steps "install add" and "install activate". In recent software, these modes are launched by default with 'synchronous' keyword that block the user session during the install operation (no prompt). Errors were detected via the device.execute(error_pattern=...) syntax.

However, with older softwares (XR < 7) these install ops are launched in the background and the initial code was expecting only success answers with the device.expect() syntax. When "install add/activate" failed in the background, the error message was not catched by the stage and the script waited the timeout.

With this change, we should be able to handle both cases. I tried to keep it coherent with the previous code in the previous steps. Also, I prefered to make the entire stage fail (by failing a step) when install add/activate fail instead of continuing for nothing.

Tristou27 avatar Dec 29 '21 08:12 Tristou27

@Tristou27 can you attach logs for this change?

lsheikal avatar Jan 07 '22 18:01 lsheikal

Changelog file have been added, sorry for the delay.

Tristou27 avatar Jan 19 '22 09:01 Tristou27