genielibs icon indicating copy to clipboard operation
genielibs copied to clipboard

Add verify_eigrp_interfaces_timers API to verify.py ios/iosxe eigrp protocol (my previous contribution) supporting EIGRPv4 and EIGRPv6 for IOS/IOSXE

Open cherifimehdi opened this issue 10 months ago • 7 comments

Hello,

I added verify_eigrp_interfaces_timers API to verify.py (my previous contribution) for ios/iosxe eigrp protocol.

I added the tests folder verify_eigrp_interfaces_timers at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/verify

I added the changelog_add_verify_eigrp_interfaces_timers_apis_202419041835 file at pkgs/sdk-pkg/changelog folder

Thank you for reviewing my contribution

cherifimehdi avatar Apr 19 '24 18:04 cherifimehdi

Hello @omehrabi @domachad here you find my PR for API pyATS contribution. Thank you

cherifimehdi avatar Apr 19 '24 19:04 cherifimehdi

Hi @omehrabi, I would just like to point out that I took into consideration for this PR all your remarks from my previous contribution. Thank you

cherifimehdi avatar Apr 22 '24 04:04 cherifimehdi

Hi @omehrabi @domachad @Harishv01 can you please review my PR, I submitted it since 02 weeks. I think this one can be merged directly since I took all the remarks from my previous PR for pyATS APIs Thanks

cherifimehdi avatar Apr 30 '24 09:04 cherifimehdi

Hi @omehrabi @domachad I did all change but test failed. Can you please assist me because normally there will be no problem. Thanks

cherifimehdi avatar May 09 '24 15:05 cherifimehdi

I tried many times always test failed!

cherifimehdi avatar May 09 '24 17:05 cherifimehdi

Please @omehrabi @domachad why tests failed?

cherifimehdi avatar May 09 '24 18:05 cherifimehdi

@omehrabi @domachad @SohanTirpude @Harishv01 I think it is better to close this PR since always tests fail when I try to update my PR according to remarks and since there is no answer why from reviewers. Thanks

cherifimehdi avatar May 12 '24 21:05 cherifimehdi