ciscoisesdk icon indicating copy to clipboard operation
ciscoisesdk copied to clipboard

Partial fix to versioning problem and lint corrections

Open elear opened this issue 2 years ago • 1 comments

This is a partial fix to the versioning problem mentioned in #64. I have not updated requirements.txt, requirements-dev.txt, or Pipfile[.lock]. This is just about the whl and some linting.

This may or may not test cleanly because the test environment didn't seem to be functioning well.

elear avatar Mar 20 '24 12:03 elear

So in other words, don't yet merge without additional testing.

elear avatar Mar 20 '24 12:03 elear

@elear , do you need any help in getting an ISE to validate this change? This request dependency thing blocks an upgrade we would need in another project (cisco-internal)..

oboehmer avatar May 01 '24 10:05 oboehmer

@oboehmer I've done my own test, but the maintainers should review the change, check the versioning, run a real test, and then check in what you think is right.

elear avatar May 01 '24 15:05 elear

@bvargasre , any feedback on #64 and Eliot's PR?

oboehmer avatar May 02 '24 09:05 oboehmer

Hi, I will accept the pr, the change will be reflected in pypi when a new tag comes out.

bvargasre avatar May 14 '24 04:05 bvargasre