devnet-express-code-samples icon indicating copy to clipboard operation
devnet-express-code-samples copied to clipboard

Published 20 hours ago • verified publisher icon CiscoDevNet

Needs Spark rename updates

Open annegentle opened this issue 6 years ago • 7 comments

Spark renamed to Webex Teams, and use ACCESS_TOKEN instead of SPARK_TOKEN - plus look for sparkbot.io renamed to webex.bot, and developer.ciscospark.com redirecting to developer.webex.com.

annegentle avatar May 24 '18 00:05 annegentle

Hey Ashley (@aroach ) I did the content changes in the devnet-express repo, but haven't circled back here. Can you take it?

annegentle avatar May 24 '18 00:05 annegentle

@annegentle are we only changing ACCESS_TOKEN -- looks like there are a lot of function names and variables with spark in them as well...

aroach avatar May 24 '18 14:05 aroach

Yeah I’m working towards removing Spark from variable names as well, using Webex or Webex Teams with matching capitalization or kebab-case as needed... see what you think of that as you dive in.

annegentle avatar May 24 '18 14:05 annegentle

See what you think of this PR for the DCI code: https://github.com/CiscoDevNet/devnet-express-dci-code-samples/pull/6

annegentle avatar May 24 '18 15:05 annegentle

ok, what about filenames too? such as spark-room-easy.py

aroach avatar May 24 '18 15:05 aroach

That's what I'm working through today... trying to move those to webex-teams-room-easy.py for example. Will require testing, yeah.

annegentle avatar May 24 '18 16:05 annegentle

I think i got all of the changes except the meraki mission. See PR #27

aroach avatar May 24 '18 21:05 aroach