ansible-meraki icon indicating copy to clipboard operation
ansible-meraki copied to clipboard

Add diff to mx_l3_firewall module

Open szeestraten opened this issue 2 years ago • 4 comments

Hi, it would be nice to have diff functionality in the mx_l3_firewall module. I saw the previous issue #37 regarding diffs so I hope it's OK to put in a request here.

szeestraten avatar Jun 10 '22 11:06 szeestraten

I was looking into this and it should be possible. The way this module works does complicate it but let me look into it.

kbreit avatar Jun 13 '22 12:06 kbreit

I've been working on this feature tonight and the module logic is awful because the default rule significantly complicates things. I may refactor the module altogether and add it then.

kbreit avatar Jun 14 '22 02:06 kbreit

@kbreit thank you very much for taking a look. The default allow any rule I presume (that caught me out a couple of times)? Just a heads up that I'll most likely touch this module in #316. If it's ok for you, I'll just work from the current implementation there.

szeestraten avatar Jun 14 '22 05:06 szeestraten

Good point. That's fine go ahead and work on the module.

kbreit avatar Jun 14 '22 10:06 kbreit