ansible-aci icon indicating copy to clipboard operation
ansible-aci copied to clipboard

Several modules have distinct options with equal aliases

Open felixfontein opened this issue 1 year ago • 1 comments

Description

Several modules have distinct options with the same aliases:

ERROR: plugins/modules/aci_aaa_user.py:0:0: option-equal-up-to-casing: Multiple options/aliases are equal up to casing: alias 'user' of option 'aaa_user', alias 'user' of option 'username'
ERROR: plugins/modules/aci_aaa_user_certificate.py:0:0: option-equal-up-to-casing: Multiple options/aliases are equal up to casing: alias 'cert_name' of option 'certificate_name', alias 'cert_name' of option 'name'
ERROR: plugins/modules/aci_epg_subnet.py:0:0: option-equal-up-to-casing: Multiple options/aliases are equal up to casing: alias 'name' of option 'epg', alias 'name' of option 'subnet_name'
ERROR: plugins/modules/aci_l3out_hsrp_secondary_vip.py:0:0: option-equal-up-to-casing: Multiple options/aliases are equal up to casing: alias 'name' of option 'hsrp_interface_group', alias 'name' of option 'interface_profile'
ERROR: plugins/modules/aci_l3out_logical_interface_profile_ospf_policy.py:0:0: option-equal-up-to-casing: Multiple options/aliases are equal up to casing: alias 'name' of option 'interface_profile', alias 'name' of option 'ospf_policy'
ERROR: plugins/modules/aci_switch_leaf_selector.py:0:0: option-equal-up-to-casing: Multiple options/aliases are equal up to casing: alias 'name' of option 'leaf', alias 'name' of option 'policy_group'
ERROR: plugins/modules/aci_vmm_credential.py:0:0: option-equal-up-to-casing: Multiple options/aliases are equal up to casing: alias 'name' of option 'domain', option 'name'

These look very much like bugs. For example, for aci_aaa_user, if the user provides user, this sets both aaa_user and username.

Ref: https://github.com/ansible/ansible/pull/83530

Affected Module Name(s):

aci_aaa_user aci_aaa_user_certificate aci_epg_subnet aci_l3out_hsrp_secondary_vip aci_l3out_logical_interface_profile_ospf_policy aci_switch_leaf_selector aci_vmm_credential

felixfontein avatar Jul 04 '24 09:07 felixfontein

Hi @felixfontein,

Thank you for raising the issue, I have added to the top of todo to fix.

akinross avatar Jul 04 '24 09:07 akinross

We have merged the fix and released v2.8.0 which include this fix.

lhercot avatar Jul 13 '24 04:07 lhercot