ansible-aci icon indicating copy to clipboard operation
ansible-aci copied to clipboard

fix: Correct vPC member side

Open timcragg opened this issue 1 year ago • 1 comments

Minor bugfix - the l3extMember object uses side instead of name to build the DN, so the module should configure the side attribute instead of the name (I believe the name attribute is left as null if you build an l3extMember object through the APIC GUI).

timcragg avatar Jun 11 '24 14:06 timcragg

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.75%. Comparing base (555a942) to head (a55c799). Report is 23 commits behind head on master.

:exclamation: There is a different number of reports uploaded between BASE (555a942) and HEAD (a55c799). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (555a942) HEAD (a55c799)
unit 8 0
integration 1 0
sanity 10 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #663       +/-   ##
===========================================
- Coverage   58.46%   35.75%   -22.72%     
===========================================
  Files         269      266        -3     
  Lines       12352    12165      -187     
  Branches     1862     1837       -25     
===========================================
- Hits         7222     4349     -2873     
- Misses       5002     7816     +2814     
+ Partials      128        0      -128     
Flag Coverage Δ
integration ?
sanity 35.75% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 11 '24 18:06 codecov[bot]

@timcragg Hi Tim, just wondering if you are still working on this one or if you have had a chance to look at the PR review comment?

samiib avatar Aug 14 '24 06:08 samiib