ansible-aci icon indicating copy to clipboard operation
ansible-aci copied to clipboard

Fabric Switch Profile tree supporting both Spines and Leaves

Open tvarohohlavy opened this issue 2 years ago • 2 comments

Renamed and updated following to support both Spines and Leaves:

  • aci_fabric_spine_switch_profile.py to aci_fabric_switch_profile.py
  • aci_fabric_spine_switch_assoc.py to aci_fabric_switch_association.py

Updated integration tests accordingly also including aci_fabric_switch_block module tests to include leaf objects.

tvarohohlavy avatar Oct 21 '21 14:10 tvarohohlavy

Related to issue: https://github.com/CiscoDevNet/ansible-aci/issues/202

tvarohohlavy avatar Nov 16 '21 07:11 tvarohohlavy

Thanks @tvarohohlavy for this contribution and sorry for the delay in our review of your PR.

This PR contains breaking changes that would impact existing users of aci_fabric_spine_profile and aci_fabric_spine_assoc.

I have added the aci_fabric_leaf_switch_assoc and aci_fabric_leaf_profile modules as part of PR #222 which also include the additional tests for aci_fabric_switch_block.

If you think we should have a single module for both leaf and spine, please modify your PR so to add the aci_fabric_switch_profile and aci_fabric_switch_assoc on top of the existing modules.

I am not sure we gain much on adding both but will let you decide if you think it is necessary.

What do you think?

lhercot avatar Dec 19 '21 01:12 lhercot