ansible-aci icon indicating copy to clipboard operation
ansible-aci copied to clipboard

ACI L4-L7 Services

Open timcragg opened this issue 2 years ago • 3 comments

This PR includes modules and integration tests for L4-L7 services. The modules allow configuration of the following ACI classes:

  • vnsCDev
  • vnsCIf
  • vnsRsCIfPathAtt
  • vnsRsCIfAttN
  • vnsLDevVip
  • vnsRsALDevToPhysDomP
  • vnsRsLDevCtxToLDev
  • vnsLIfCtx
  • vnsRsLIfCtxToBD
  • vnsRsLIfCtxToLIf
  • vnsRsLIfCtxToSvcRedirectPol
  • vnsLDevCtx
  • vnsLIf
  • svcRedirectPol
  • vnsRedirectDest
  • vnsRsRedirectHealthGroup
  • vnsRsIPSLAMonitoringPol
  • vnsRedirectHealthGroup
  • vnsRsIPSLAMonitoringPol
  • vnsRedirectHealthGroup
  • vnsAbsGraph
  • vnsAbsConnection
  • vnsRsAbsConnectionConns
  • vnsAbsFuncConn
  • vnsAbsNode
  • vnsAbsTermNodeCon
  • vnsAbsTermNodeProv
  • vnsAbsTermConn
  • fvIPSLAMonitoringPol

timcragg avatar Sep 01 '21 16:09 timcragg

Codecov Report

Attention: Patch coverage is 38.76404% with 436 lines in your changes are missing coverage. Please review.

Project coverage is 35.70%. Comparing base (a1f32b7) to head (5e164a7). Report is 5 commits behind head on master.

Files Patch % Lines
...ins/modules/aci_l4l7_policy_based_redirect_dest.py 20.54% 58 Missing :warning:
...ns/modules/aci_l4l7_device_selection_if_context.py 24.19% 47 Missing :warning:
plugins/modules/aci_l4l7_policy_based_redirect.py 33.33% 34 Missing :warning:
plugins/modules/aci_ip_sla_monitoring_policy.py 34.69% 32 Missing :warning:
plugins/modules/aci_l4l7_device.py 36.36% 28 Missing :warning:
...lugins/modules/aci_l4l7_device_selection_policy.py 36.58% 26 Missing :warning:
...ns/modules/aci_l4l7_service_graph_template_node.py 39.53% 26 Missing :warning:
...dules/aci_l4l7_service_graph_template_term_node.py 38.09% 26 Missing :warning:
...4l7_service_graph_template_abs_connection_conns.py 40.54% 22 Missing :warning:
plugins/modules/aci_l4l7_concrete_interface.py 44.44% 20 Missing :warning:
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #186       +/-   ##
===========================================
- Coverage   58.61%   35.70%   -22.91%     
===========================================
  Files         256      276       +20     
  Lines       11791    12631      +840     
  Branches     1786     1902      +116     
===========================================
- Hits         6911     4510     -2401     
- Misses       4768     8121     +3353     
+ Partials      112        0      -112     
Flag Coverage Δ
integration ?
sanity 35.70% <38.76%> (+0.20%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 13 '23 16:04 codecov[bot]

please also rebase on latest code, this will like also remove the pep8 empty line end of file issue in aci.py

akinross avatar Jun 22 '23 13:06 akinross

Please fix sanity and black formatting, then I can approve.

Done

timcragg avatar Jun 27 '23 13:06 timcragg