mobile-app icon indicating copy to clipboard operation
mobile-app copied to clipboard

improve text contrast for inactive tabs in dark mode

Open sahu-virendra-1908 opened this issue 7 months ago • 2 comments

Describe the bug In dark mode, the text on inactive tabs (e.g., "Circuits") within the profile screen has insufficient contrast, making it difficult to read.

To Reproduce Steps to reproduce the behavior:

Switch to dark mode.

Navigate to the profile screen.

Click on any inactive tab (like "Circuits").

Observe that the inactive tab's text is hard to read due to low contrast.

Expected behavior The inactive tab text should maintain sufficient contrast against the dark background to ensure readability.

[Dark Mode UI Issue] Inactive Tab Text Lacks Contrast and is Difficult to Read #317

Describe the changes you have made in this PR

Updated the unselectedLabelColor in lib/ui/views/profile/profile_view.dart from Colors.black87 to Colors.white to ensure better text visibility in dark mode.

Screenshots
after changes WhatsApp Image 2025-05-25 at 23 57 48_5dced0dc

Summary by CodeRabbit

  • Style
    • Updated the color of unselected tab labels in the profile view for improved visual appearance.

sahu-virendra-1908 avatar Jun 07 '25 19:06 sahu-virendra-1908

Walkthrough

The change updates the unselectedLabelColor property of the TabBar in the ProfileView class, altering the color from Colors.black87 to Colors.white. This adjustment affects only the visual appearance of unselected tab labels, with no modifications to logic or exported entities.

Changes

File(s) Change Summary
lib/ui/views/profile/profile_view.dart Changed TabBar's unselectedLabelColor from Colors.black87 to Colors.white.

Possibly related issues

  • CircuitVerse/mobile-app#317: Addresses the same concern about unselected tab label color and inactive tab text readability in the ProfileView's TabBar.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 07 '25 19:06 coderabbitai[bot]

Hey @sahu-virendra-1908 , Please pull the latest commit of the repo to make new changes as we updated the flutter version.

hardik17771 avatar Jun 09 '25 16:06 hardik17771