mobile-app icon indicating copy to clipboard operation
mobile-app copied to clipboard

light-dark mode toggle

Open NitinSohal opened this issue 9 months ago • 2 comments

Fixes #

Describe the changes you have made in this PR -

This PR improves the dark mode toggle by turning it into a more intuitive switch and placing it at the top of the drawer. The new placement enhances visibility and access, leading to a better overall user experience. The change ensures theme switching feels natural and easily reachable.

  • Made the Dark Mode button into a toggle switch for easier use.

  • Improved visibility and interaction, making it more user-friendly.

  • Moved it to the top of the drawer so users can find it quickly.

  • Placement is now cleaner and more intuitive — no longer awkwardly hidden.

  • Overall enhances the user experience and makes switching themes smoother.

Screenshots of the changes (If any) -

Screenshot 2025-04-05 at 11 18 40 PM

older light view

Screenshot 2025-04-05 at 11 19 35 PM

new light view

Screenshot 2025-04-05 at 11 20 44 PM

old dark view

Screenshot 2025-04-05 at 11 20 01 PM

new dark view

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Summary by CodeRabbit

  • New Features
    • Integrated a unified dark/light theme toggle into the main drawer for a smoother experience.
    • The new control dynamically updates its label and icon with an animated transition based on the current theme.
    • Removed a redundant theme switch button to streamline the interface.

NitinSohal avatar Apr 05 '25 18:04 NitinSohal

Walkthrough

The update modifies the theme switching capability in the CVDrawer component. It introduces a new ListTile widget that consolidates theme toggle functionality. This widget features an AnimatedSwitcher for the leading icon, dynamically switching between sun and moon icons based on the theme, and updates its title to reflect "Dark Mode" or "Light Mode". A Switch widget in the trailing position allows users to change the theme via the nextTheme callback. The previous top-right IconButton for theme switching was removed, streamlining the interface.

Changes

File Summary of Changes
lib/ui/components/cv_drawer.dart Added a new ListTile for theme switching with an AnimatedSwitcher for icons, dynamic text for themes, and a Switch widget. Removed the redundant IconButton.
lib/l10n/app_en.arb Added new entries: "light_mode": "Light Mode" and "dark_mode": "Dark Mode" for localization support of theme options.
lib/l10n/app_hi.arb Added new entries: "light_mode": "लाइट मोड" and "dark_mode": "डार्क मोड" for localization support of theme options; existing entry for "contact_us_text" remains unchanged.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 05 '25 18:04 coderabbitai[bot]

Pull Request Test Coverage Report for Build 14284412400

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 63.984%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/components/cv_drawer.dart 0 22 0.0%
<!-- Total: 0 22
Totals Coverage Status
Change from base Build 14281420433: -0.2%
Covered Lines: 4047
Relevant Lines: 6325

💛 - Coveralls

coveralls avatar Apr 05 '25 18:04 coveralls

Hey @NitinSohal , the text style or font you added does not follow our app's theme. Also add translations wherever needed for the text. Please make these changes.

hardik17771 avatar Apr 06 '25 16:04 hardik17771

Solved all the issue in the new PR

NitinSohal avatar Apr 07 '25 09:04 NitinSohal