mobile-app icon indicating copy to clipboard operation
mobile-app copied to clipboard

Terms of service button fix

Open JatsuAkaYashvant opened this issue 9 months ago • 2 comments

Fixes #

Fixed the issue number: #332

Describe the changes you have made in this PR -

  1. Fixed text overflow issues in Terms of Service/Privacy Policy buttons by implementing proper text scaling
  2. Optimized layout implementation to prevent text wrapping while maintaining responsiveness
  3. Improved visual hierarchy with better spacing and alignment

Screenshots of the changes (If any) -

Before:

WhatsApp Image 2025-04-05 at 00 12 47_7a30da2a

After:

WhatsApp Image 2025-04-05 at 22 52 29_e63d34a1

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Summary by CodeRabbit

  • Style
    • Refined the layout of the Terms of Service and Privacy Policy buttons on the About page.
    • Reduced vertical spacing and added consistent horizontal padding for a cleaner, more streamlined appearance.
    • Updated button appearance to a smaller variant, enhancing the overall visual presentation.

JatsuAkaYashvant avatar Apr 05 '25 14:04 JatsuAkaYashvant

Walkthrough

The changes adjust the layout and styling of the Terms of Service and Privacy Policy buttons in the About view. The vertical margin around the container has been reduced, and each button is now wrapped in horizontal padding. Additionally, the buttons have been updated to use the small variant of the primary button widget by removing the isBodyText parameter. No changes have been made to the exported or public entity declarations.

Changes

Files Summary
lib/ui/views/about/about_view.dart Modified the _buildTosAndPrivacyButtons method by reducing the vertical margin from 32 to 12, adding horizontal padding of 4, and switching to the small variant of CVPrimaryButton by removing the isBodyText parameter.

Possibly related PRs

  • CircuitVerse/mobile-app#331: Addresses modifications to the CVPrimaryButton component by introducing a new factory constructor for the small variant, which aligns with changes in this PR.

Suggested labels

released


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de8b8c0cfacedb7967ae2d23d18db39e131a2d11 and 190115b0e967862beddd39ce612f3b6936ada796.

📒 Files selected for processing (1)
  • lib/ui/views/about/about_view.dart (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • lib/ui/views/about/about_view.dart
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build (windows-latest)
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: build (macos-latest)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 05 '25 14:04 coderabbitai[bot]

Pull Request Test Coverage Report for Build 14284185934

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 64.146%

Files with Coverage Reduction New Missed Lines %
lib/ui/components/cv_primary_button.dart 2 88.24%
<!-- Total: 2
Totals Coverage Status
Change from base Build 14281420433: -0.02%
Covered Lines: 4047
Relevant Lines: 6309

💛 - Coveralls

coveralls avatar Apr 05 '25 15:04 coveralls

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Jun 13 '25 12:06 github-actions[bot]