mobile-app icon indicating copy to clipboard operation
mobile-app copied to clipboard

[fix#266] Show a spinner when the API request for Star an repo is running

Open notbrood opened this issue 3 years ago • 2 comments

Fixes #266

Describe the changes you have made in this PR -

  • Added a boolean to check if the repo is being starred.
  • Added a CircularProgressIndicator with a ternary operator.

Screenshots of the changes (If any) -

https://user-images.githubusercontent.com/91044746/223662186-fb195cfb-222d-4bf9-92c4-6ed2e4959e45.mp4

notbrood avatar Mar 08 '23 08:03 notbrood

Pull Request Test Coverage Report for Build 4362487337

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 64.619%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/projects/project_details_view.dart 8 10 80.0%
<!-- Total: 8 10
Files with Coverage Reduction New Missed Lines %
lib/ui/views/projects/project_details_view.dart 1 43.45%
<!-- Total: 1
Totals Coverage Status
Change from base Build 4335726683: -0.01%
Covered Lines: 4060
Relevant Lines: 6283

💛 - Coveralls

coveralls avatar Mar 11 '23 08:03 coveralls

Hey @notbrood, this can be easily implemented with isBusy method and pass in the TOGGLE_STAR key. Check this for reference.

cc @manjotsidhu

aman-singh7 avatar May 27 '23 09:05 aman-singh7