mobile-app
mobile-app copied to clipboard
bfix(markdown)!: fix inline html parsing
Fixes #196
Describe the changes you have made in this PR -
Inline HTML Elements
between backticks (`) are not parsed. So, I have split the content between ` and if there exist HTML elements in between them then omitted the `.
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.
Pull Request Test Coverage Report for Build 2015709823
- 3 of 16 (18.75%) changed or added relevant lines in 3 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.2%) to 70.563%
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
---|---|---|---|
lib/ui/views/ib/syntaxes/ib_backticks_syntax.dart | 1 | 14 | 7.14% |
<!-- | Total: | 3 | 16 |
Totals | |
---|---|
Change from base Build 1981608503: | -0.2% |
Covered Lines: | 3912 |
Relevant Lines: | 5544 |
💛 - Coveralls
Good effort @aman-singh7, I will review it soon.
@manjotsidhu Ok, I will work on the fork of flutter_markdown in CircuitVerse (i.e CircuitVerse/packages) and try to it include it there. :+1:
@manjotsidhu Ok, I will work on the fork of flutter_markdown in CircuitVerse (i.e CircuitVerse/packages) and try to it include it there. :+1:
Ok, it's upto you. Other way (can be the best way) can also be to introduce custom builder which will build the blockquote in our way.
@manjotsidhu Ok, I will work on the fork of flutter_markdown in CircuitVerse (i.e CircuitVerse/packages) and try to it include it there. +1
Ok, it's upto you. Other way (can be the best way) can also be to introduce custom builder which will build the blockquote in our way.
Ok cool, I will implement this way :+1:
@manjotsidhu The custom builder has been implemented.