mobile-app icon indicating copy to clipboard operation
mobile-app copied to clipboard

bfix(markdown)!: fix inline html parsing

Open aman-singh7 opened this issue 2 years ago • 6 comments

Fixes #196

Describe the changes you have made in this PR - Inline HTML Elements between backticks (`) are not parsed. So, I have split the content between ` and if there exist HTML elements in between them then omitted the `.

Screenshot from 2022-03-08 11-18-16

Screenshots of the changes (If any) - WhatsApp Image 2022-03-08 at 10 54 20 AM

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

aman-singh7 avatar Mar 08 '22 05:03 aman-singh7

Pull Request Test Coverage Report for Build 2015709823

  • 3 of 16 (18.75%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 70.563%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/ib/syntaxes/ib_backticks_syntax.dart 1 14 7.14%
<!-- Total: 3 16
Totals Coverage Status
Change from base Build 1981608503: -0.2%
Covered Lines: 3912
Relevant Lines: 5544

💛 - Coveralls

coveralls avatar Mar 08 '22 05:03 coveralls

Good effort @aman-singh7, I will review it soon.

manjotsidhu avatar Mar 10 '22 05:03 manjotsidhu

@manjotsidhu Ok, I will work on the fork of flutter_markdown in CircuitVerse (i.e CircuitVerse/packages) and try to it include it there. :+1:

aman-singh7 avatar Mar 11 '22 11:03 aman-singh7

@manjotsidhu Ok, I will work on the fork of flutter_markdown in CircuitVerse (i.e CircuitVerse/packages) and try to it include it there. :+1:

Ok, it's upto you. Other way (can be the best way) can also be to introduce custom builder which will build the blockquote in our way.

manjotsidhu avatar Mar 14 '22 15:03 manjotsidhu

@manjotsidhu Ok, I will work on the fork of flutter_markdown in CircuitVerse (i.e CircuitVerse/packages) and try to it include it there. +1

Ok, it's upto you. Other way (can be the best way) can also be to introduce custom builder which will build the blockquote in our way.

Ok cool, I will implement this way :+1:

aman-singh7 avatar Mar 14 '22 16:03 aman-singh7

@manjotsidhu The custom builder has been implemented.

aman-singh7 avatar Mar 21 '22 11:03 aman-singh7