mobile-app icon indicating copy to clipboard operation
mobile-app copied to clipboard

Fix and enable linter rules

Open Neha62-lit opened this issue 4 years ago • 8 comments

Is your feature request related to a problem? Please describe.

Yes, In flutter-lints dependency, there are so many linter rules that I disabled in PR #148

Now here are the checklists of the lint rules that are disabled (enabled rules are marked as checked) :

  • [x] always_declare_return_types
  • [x] avoid_print
  • [x] avoid_unnecessary_containers
  • [x] prefer_if_elements_to_conditional_expressions
  • [x] prefer_const_constructors
  • [x] prefer_const_declarations
  • [x] unnecessary_string_interpolations
  • [x] sized_box_for_whitespace
  • [x] prefer_single_quotes
  • [x] prefer_const_constructors_in_immutables
  • [x] use_key_in_widget_constructors
  • [x] prefer_function_declarations_over_variables
  • [x] unnecessary_string_escapes
  • [x] avoid_function_literals_in_foreach_calls
  • [x] prefer_interpolation_to_compose_strings
  • [x] unnecessary_parenthesis
  • [x] sort_constructors_first
  • [x] always_put_required_named_parameters_first
  • [ ] avoid_classes_with_only_static_members
  • [x] avoid_redundant_argument_values
  • [x] join_return_with_assignment
  • [ ] non_constant_identifier_names
  • [x] constant_identifier_names
  • [ ] no_leading_underscores_for_local_identifiers
  • [ ] library_private_types_in_public_api
  • [ ] depend_on_referenced_packages
  • [ ] use_build_context_synchronously This rule will be intentionally be disabled since we use ALL_CAPS_WITH_UNDERSCORES for constants.

Neha62-lit avatar Oct 06 '21 07:10 Neha62-lit

Hey @manjotsidhu, Now I have to create a single PR of one rule at a time, right?

Neha62-lit avatar Oct 06 '21 07:10 Neha62-lit

Hey @manjotsidhu, Now I have to create a single PR of one rule at a time, right?

Yes

manjotsidhu avatar Oct 06 '21 07:10 manjotsidhu

@manjotsidhu can I work on the remaining ones?

aman-singh7 avatar Nov 23 '21 09:11 aman-singh7

@manjotsidhu can i work on some of the remaining one?

Aadeesh11 avatar Dec 05 '21 09:12 Aadeesh11

@manjotsidhu can I work on some of the remaining.

devansh12b2 avatar Dec 05 '21 20:12 devansh12b2

@ItsAdityaKSingh is this still open to MR ?

remote007 avatar Feb 10 '22 02:02 remote007

@remote007 I have made a PR for it which hasn't been reviewed yet.

ItsAdityaKSingh avatar Feb 10 '22 07:02 ItsAdityaKSingh