cv-frontend-vue icon indicating copy to clipboard operation
cv-frontend-vue copied to clipboard

Improve Browser Performance in ExportProject.vue by Adopting Vue Best Practices

Open Jay2006sawant opened this issue 10 months ago • 4 comments

Fixes #469

Describe the changes you have made in this PR -

This PR addresses the issue where setTimeout was used in the ExportProject.vue file, replacing it with Vue's nextTick lifecycle hook to improve efficiency and reduce browser load for end users. This aligns with Vue best practices and ensures better performance in the simulator.


Note:

  • This change specifically impacts the ExportProject.vue file and does not affect other parts of the project.
  • Please check Allow edits from maintainers. if you would like us to assist in the PR.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced the export dialog to automatically focus the file name input when opened, ensuring a smoother and more intuitive user experience.

Jay2006sawant avatar Feb 15 '25 15:02 Jay2006sawant

Walkthrough

The change updates the ExportProject.vue component by switching to the <script setup> syntax and refining the input focus logic. The update imports watch and nextTick from Vue, and replaces the use of setTimeout with nextTick to ensure that the file name input field is focused after DOM updates when the dialog opens.

Changes

File Path Change Summary
src/components/DialogBox/ExportProject.vue Updated to use <script setup> syntax; imported watch and nextTick from Vue; replaced setTimeout with nextTick to correctly focus input

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant D as DialogBox Component
    participant V as Vue (nextTick)
    
    U->>D: Opens dialog
    D->>V: Call nextTick for DOM update
    V-->>D: DOM updated
    D->>D: Focus fileNameInputField
    D->>U: Dialog ready for input

Possibly related PRs

  • CircuitVerse/cv-frontend-vue#481: Updates in the ExportProject.vue file, switching from setTimeout to nextTick for improved DOM update handling and input focus.

Poem

I'm a rabbit with a hop so free,
In a dialog box, changes came to be.
NextTick knocks, the DOM is set,
Input focused, no more fret!
Hop on through, code's in glee!
🐰🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Feb 15 '25 15:02 coderabbitai[bot]

Deploy Preview for circuitverse ready!

Name Link
Latest commit 755a03b24fdc45230902038fffe97749009c9eac
Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/67b0b7fe2b7f390008faf013
Deploy Preview https://deploy-preview-484--circuitverse.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 15 '25 15:02 netlify[bot]

@Arnabdaz PTAL

Jay2006sawant avatar Feb 17 '25 10:02 Jay2006sawant

cc: @JoshVarga @Arnabdaz

Jay2006sawant avatar Feb 19 '25 09:02 Jay2006sawant