Interactive-Book icon indicating copy to clipboard operation
Interactive-Book copied to clipboard

minor change

Open prabhleenkaur1007 opened this issue 5 years ago • 9 comments

did minor changes, which are easy to ignore but better be corrected :-))

prabhleenkaur1007 avatar Jan 24 '20 16:01 prabhleenkaur1007

@prabhleenkaur1007 adding screenshots of the change would be helpful.

Ananthavijay avatar Jan 24 '20 16:01 Ananthavijay

Adding a descriptive title and description along with some screenshots would have us to review it better @prabhleenkaur1007

aayushgupta05 avatar Jan 24 '20 19:01 aayushgupta05

@prabhleenkaur1007 adding screenshots of the change would be helpful.

for the first commit, the change is only in the width of the top two buttons. before after

for the second commit, the change is in the alignment of the link "combinational circuits". before2 after2

let me know, if it is helpful. i would love to contribute more.

prabhleenkaur1007 avatar Jan 24 '20 20:01 prabhleenkaur1007

Update commit title and description to consisely say what you have changed. Some commit messages should also be more specific, and use capital letters. Also follow Hound's instructions.

JoshHeng avatar Jan 24 '20 23:01 JoshHeng

@prabhleenkaur1007 overlap of breadcrumb nav is not the Only problem. Try opening and closing the sidebar by clicking the sudebar button, breadcrumb nav would not move

Ananthavijay avatar Jan 25 '20 01:01 Ananthavijay

my sincere apologies for the delay in reply.

the commit, "ADDED DISCUS.HTML" was done because many pages are missing the last column. i will also commit this change for remaining other pages(which are missing this) soon. discus

the commit, "MADE THE LINKS WORKING" is very clear i think. Before and After screenshots are below. reference reference2

prabhleenkaur1007 avatar Jan 25 '20 13:01 prabhleenkaur1007

@prabhleenkaur1007 you are not supposed to add so many changes in one single pr. Make separate prs to solve various issues with proper title, description and screenshots. Also, please check before solving an issue if it has been solved before, check standing prs and try claiming a task before working on it.

aayushgupta05 avatar Jan 25 '20 14:01 aayushgupta05

@prabhleenkaur1007 I have already fixed the overlapping issue in this PR. Before working on a bug/feature, first create an issue on it and then start working.

Ananthavijay avatar Jan 25 '20 14:01 Ananthavijay

@aayush-05 and @Ananthavijay, i will abide by the instructions in the future. THANK YOU This is my first contribution to such an amazingly huge community.

prabhleenkaur1007 avatar Jan 26 '20 06:01 prabhleenkaur1007