Interactive-Book icon indicating copy to clipboard operation
Interactive-Book copied to clipboard

Dark mode issues

Open NumberC opened this issue 4 years ago • 12 comments

Fixes Issue #7

Changes have been made to inputs, select/option, Interactive FSM, and Boolean Function. It should look nicer now!

Inputs: Capture3

Select/Option: Capture2

Interactive FSM: Capture

Boolean Function: Capture4 Capture5

Light Counterpart Still Works: 1 2 3 4 5

NumberC avatar Dec 22 '19 20:12 NumberC

Can you provide me with the screenshots of the webpage in the light mode as well to let me see your code isn't breaking that. Also, please take care of hound.

aayushgupta05 avatar Dec 24 '19 03:12 aayushgupta05

@aayush-05 Can you check it now?

NumberC avatar Dec 24 '19 04:12 NumberC

Solve the hound issues too, specially the ones regarding declaring the sass variables separately.

aayushgupta05 avatar Dec 24 '19 15:12 aayushgupta05

There is no way for me to really resolve "Avoid using id selectors" or "Selector soda_machine_fsm_canvas should be written in lowercase with hyphens"

NumberC avatar Dec 24 '19 15:12 NumberC

Ignore that ones. Have you linked the netlify integration to your forked version of the repo, try doing it with the CircuitVerse's original repo. Also, is it really required to change the jquery version ?

aayushgupta05 avatar Dec 24 '19 15:12 aayushgupta05

Thank you! I didn't know the JQuery version was out dated. As for Netlify, I believe I set it up in _config.yml: repository: NumberC/Interactive-Book

NumberC avatar Dec 24 '19 17:12 NumberC

Remove the additional change you have made to pass the netlify tests, no problem even if the test fails.

aayushgupta05 avatar Dec 25 '19 19:12 aayushgupta05

@tachyons @ankitkataria do have a look at this.

aayushgupta05 avatar Dec 25 '19 20:12 aayushgupta05

@NumberC please fix the conflicts.

aayushgupta05 avatar Feb 20 '20 15:02 aayushgupta05

@aayush-05 what conflicts are there?

NumberC avatar Feb 20 '20 16:02 NumberC

It looks like changes have been made to the truth_table.html file after you have raised this issue. Pull the changes from the master and then make your changes in that file.

aayushgupta05 avatar Feb 20 '20 18:02 aayushgupta05

@aayush-05 I fixed the conflicts

NumberC avatar Feb 22 '20 05:02 NumberC