CircuitVerseDocs icon indicating copy to clipboard operation
CircuitVerseDocs copied to clipboard

Wrong label on dark mode toggler

Open ShreyaPrasad1209 opened this issue 3 years ago • 11 comments

Describe the bug

The dark mode toggle has "Edit on GitHub" written on it instead of "Dark Mode". This can confuse many users as they might assume it to be a link to GitHub.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'https://docs.circuitverse.org/#/'
  2. Click on 'Edit on GitHub' on top right
  3. You will see it is a dark mode toggler

Expected behavior

Change name of "Edit on GitHub" to "Dark Mode".

Screenshot

image

Device Information [optional]:

  • OS: Windows 10
  • Browser: Edge

Are you working on this issue? (Yes/No)

No this issue is reserved for Open Source Day participants.

ShreyaPrasad1209 avatar Jun 21 '21 12:06 ShreyaPrasad1209

I guess 'Edit on GitHub' is a link for contributing to that webpage on GitHub. Do we have to mention somewhere around the toggle about the dark and light mode?

StarTrooper08 avatar Jul 01 '21 20:07 StarTrooper08

@ShreyaPrasad1209 Can you assign this to me?

deepxcode avatar Jul 02 '21 07:07 deepxcode

Hi, I am interested to take this up. Just to clarify - the edit link does take us to github page. Should this be retained along with introducing a new label for Dark Mode or can I just remove the edit link and just include the dark mode label in there?

vvijayalakshmi21 avatar Jul 15 '21 16:07 vvijayalakshmi21

Is this issue available I am interested to take up?

labbasaiteja avatar Jul 15 '21 20:07 labbasaiteja

hey can i work on this for OSD, I couldn't make it that time ?

dineshkumar12004 avatar Jul 18 '21 13:07 dineshkumar12004

i would like to work on this issue

Kartikay304 avatar Sep 05 '21 06:09 Kartikay304

@Kartikay304 sure

ShreyaPrasad1209 avatar Sep 07 '21 10:09 ShreyaPrasad1209

@Kartikay304 sure

Thanks, I guess the edit link does take us to github page. Should this be retained along with introducing a new label for Dark Mode or can I just remove the edit link and just include the dark mode label in there?

Kartikay304 avatar Sep 07 '21 14:09 Kartikay304

hey @ShreyaPrasad1209, can you please assign this issue to me?

PaarthAgarwal avatar Jan 28 '22 09:01 PaarthAgarwal

Hey @ShreyaPrasad1209 if this issue is still open can you please assign it to me??

Adarsh9306 avatar Apr 02 '23 16:04 Adarsh9306

can you please assign it to me ?

chiragmalik2612 avatar Nov 19 '23 09:11 chiragmalik2612