CircuitVerseDocs icon indicating copy to clipboard operation
CircuitVerseDocs copied to clipboard

The toggle button for dark button needs a label.

Open PragatiVerma18 opened this issue 5 years ago • 16 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

The toggle button on the docs page( https://docs.circuitverse.org/#/ ) did not specify its purpose. Separate it from the edit on GitHub link. It is confusing at first sight.

Additional context Add any other context or screenshots about the feature request here.

toggle

PragatiVerma18 avatar Oct 31 '19 18:10 PragatiVerma18

Hi, How does this look?

dark-mode-toggle-fix

I am actually very new (this is my first issue :) ) to this repository and I am not yet aware of the structure of the codebase. It would be helpful if you could point me to the HTML/CSS files.

Thank you.

CodeSarthak avatar Oct 31 '19 18:10 CodeSarthak

Hi, @CodeSarthak!!! This is cool but I can't help you with further stuff since I am just a contributor to this project and I don't have push permissions. So, wait for the reviewers to look at your solution. The HTML/CSS files you will find them here: https://github.com/CircuitVerse/CircuitVerse/tree/master/public

PragatiVerma18 avatar Oct 31 '19 18:10 PragatiVerma18

Sure, I'll wait for the approval and then start working on it.

Thanks a lot @PragatiVerma18. Just a small thing - I was able to locate the CSS files but I am still unable to find the HTML source files :(

CodeSarthak avatar Oct 31 '19 19:10 CodeSarthak

Here you go : https://github.com/CircuitVerse/CircuitVerseDocs/blob/master/docs/index.html

I guess we were looking at the wrong place. There is a separate repository for the CircuitVerse docs: https://github.com/CircuitVerse/CircuitVerseDocs

PragatiVerma18 avatar Nov 01 '19 07:11 PragatiVerma18

Right. Thank you once again.

CodeSarthak avatar Nov 01 '19 11:11 CodeSarthak

@satu0king

tachyons avatar Nov 02 '19 05:11 tachyons

Hi, How does this look?

dark-mode-toggle-fix

I am actually very new (this is my first issue :) ) to this repository and I am not yet aware of the structure of the codebase. It would be helpful if you could point me to the HTML/CSS files.

Thank you.

That looks good, you can just write toggle theme instead of go dark and try and avoid space between edit on github and the toggle button.

Thank You

satu0king avatar Nov 02 '19 05:11 satu0king

Thank you for the feedback @satu0king . I have made the improvements :

updated-toggle-theme

Please do recommend any other changes if required.

CodeSarthak avatar Nov 02 '19 06:11 CodeSarthak

Here you go : https://github.com/CircuitVerse/CircuitVerseDocs/blob/master/docs/index.html

I guess we were looking at the wrong place. There is a separate repository for the CircuitVerse docs: https://github.com/CircuitVerse/CircuitVerseDocs

Thank you for your help @PragatiVerma18 but this HTML file is not the correct one :(

CodeSarthak avatar Nov 02 '19 08:11 CodeSarthak

Can someone point me to the appropriate HTML file? Still not able to locate it :(

CodeSarthak avatar Nov 05 '19 16:11 CodeSarthak

I guess you are looking for this @CodeSarthak : https://github.com/CircuitVerse/CircuitVerseDocs/blob/e62b6e8598ccee775a1caeb2ac2d128c62d6e13f/docs/index.html

aayushgupta05 avatar Nov 09 '19 18:11 aayushgupta05

Mentioning duplicate Issues for reference

  • #213
  • #212
  • #154

YashKumarVerma avatar May 15 '20 12:05 YashKumarVerma

@YashKumarVerma Should we implement something like this? darkMode

nileshdas avatar Jun 16 '20 08:06 nileshdas

@YashKumarVerma Should we implement something like this? darkMode

I think we should match it with the CircuitVerse Theme. @YashKumarVerma views.

Shivansh2407 avatar Jun 16 '20 08:06 Shivansh2407

@YashKumarVerma Should we implement something like this? darkMode

I think we should match it with the CircuitVerse Theme. @YashKumarVerma views.

Agreed. We have everything in a simple design. @Shivansh2407 how about https://facebook.github.io/watchman/

YashKumarVerma avatar Jun 17 '20 16:06 YashKumarVerma

This looks good but we can implement it after making changes like replacing blue shadow with green to match CV theme. Let me know your views.

Shivansh2407 avatar Jun 19 '20 12:06 Shivansh2407