CircuitVerse
CircuitVerse copied to clipboard
fix: project name saving in both tables
Fixes #450
Describe the changes you have made in this PR -
When we edit the title from edit project page, it only updates the projects table. But the project name is also stored in project_data table. On simulator page we get the project name and details from the project_data table. So this pr will be to updae the project name in project_data table too.
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.
⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Generic Password | 2236fdf6ef40a2adbd4875fa30c430e1673851e7 | docker-compose.yml | View secret | |
- | Generic Password | 5fe673456c484f048b91a3185a19e3b50e024bf9 | docker-compose.yml | View secret | |
- | Generic Password | 0292c97d08ea4f6c2c5eb86d91af7056d885df29 | config/database.docker.yml | View secret | |
- | Generic Password | c177d2ce332ca1dcc7cf26ec36b200dee9ca36cc | docker-compose.yml | View secret | |
- | Generic Password | 81b37b80e49833021f7a7c5ba89ba2c9b258ff19 | docker-compose.yml | View secret | |
- | Generic Password | 0292c97d08ea4f6c2c5eb86d91af7056d885df29 | docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Code Climate has analyzed commit 813f3e40 and detected 0 issues on this pull request.
View more on Code Climate.
@Pulkit0729 could you add test cases for the changes. Ref: https://mixandgo.com/learn/ruby-on-rails/3-ways-of-testing-private-methods-in-rails