CircuitVerse icon indicating copy to clipboard operation
CircuitVerse copied to clipboard

Error-Message style missing in "Assignment" section

Open Malavi1 opened this issue 1 year ago • 17 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Describe the bug

Throughout the application we are showing the error message with only one style as shown in the below.

Screenshot from 2024-01-13 17-29-14 Screenshot from 2024-01-13 17-38-00

But assignment error message missing this style.

Screenshot from 2024-01-13 17-26-38

Steps To Reproduce

dahsboard->try to create assignment without name

Expected Behavior

To make it consistent we have to add styling to this section too

Screenshot from 2024-01-13 17-52-55

Screenshots

No response

Device Information [optional]

- OS:
- Browser:
- version:

Additional context

No response

Are you working on this issue?

No

Malavi1 avatar Jan 13 '24 12:01 Malavi1

I think we just need to add CSS styling , or toast to fix this bug, please assign me this issue

SharanRP avatar Jan 13 '24 12:01 SharanRP

Assign me

igennova avatar Jan 13 '24 15:01 igennova

ig i got the issue actually it is showing message but we just need to style the message @Malavi1 right??

image

upsaurav12 avatar Jan 13 '24 17:01 upsaurav12

assign me

priyanshagra avatar Jan 14 '24 06:01 priyanshagra

ig i got the issue actually it is showing message but we just need to style the message @Malavi1 right??

image

It is also one of the ways, or as we already have error-message styling simply name the div with that

Malavi1 avatar Jan 14 '24 11:01 Malavi1

I think we just need to add CSS styling , or toast to fix this bug, please assign me this issue

You can work on the issue

tanmoysrt avatar Jan 15 '24 05:01 tanmoysrt

Is this issue still open??

sahilarora02 avatar Jan 18 '24 14:01 sahilarora02

Is this issue still open??

No this issue is assigned to someone else if u dont know that how to know that the issye is assigned to someone then pls check assignees in assignee tag

upsaurav12 avatar Jan 18 '24 14:01 upsaurav12

I would like to work on this if no one is working. (since no pr even after 2 weeks)

Chandrachur67 avatar Jan 29 '24 13:01 Chandrachur67

@tanmoysrt @Malavi1 I have solved the issue. I hope this is the desired behaviour.

please assign this to me if possible. I can raise a pr as soon as it is assigned to me. I have made the change in all the places where this inconsistency could have occurred.

Image reflecting the change

Before After
Screenshot 2024-01-29 at 7 50 46 PM Screenshot 2024-01-29 at 7 46 37 PM

Chandrachur67 avatar Jan 29 '24 14:01 Chandrachur67

Hi @SharanRP any update ?

tanmoysrt avatar Jan 29 '24 21:01 tanmoysrt

sorry ,I couldn't find the correct file to make changes

SharanRP avatar Jan 31 '24 13:01 SharanRP

Thanks @SharanRP for the update

tanmoysrt avatar Jan 31 '24 14:01 tanmoysrt

@tanmoysrt @Malavi1 I have solved the issue. I hope this is the desired behaviour.

please assign this to me if possible. I can raise a pr as soon as it is assigned to me. I have made the change in all the places where this inconsistency could have occurred.

Image reflecting the change

Before After Screenshot 2024-01-29 at 7 50 46 PM Screenshot 2024-01-29 at 7 46 37 PM

You can raise PR for the issue fix

tanmoysrt avatar Jan 31 '24 14:01 tanmoysrt

Hey @tanmoysrt , I have raised the pr. thank you.

Chandrachur67 avatar Feb 01 '24 19:02 Chandrachur67

@tanmoysrt i want to work on this issue please assign this to me

lavi20 avatar Feb 27 '24 10:02 lavi20

hey @lavi20 for this issue there is already raised pr opened so you can check other issue that are not assign to someone else or you can make you own issue also

upsaurav12 avatar Feb 27 '24 15:02 upsaurav12