CircuitVerse icon indicating copy to clipboard operation
CircuitVerse copied to clipboard

feat(api): add mentors in the group

Open aman-singh7 opened this issue 3 years ago • 6 comments

Signed-off-by: Aman [email protected]

Fixes #3234

Describe the changes you have made in this PR -

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

aman-singh7 avatar Jul 13 '22 14:07 aman-singh7

Coverage Status

Coverage increased (+0.08%) to 81.919% when pulling 5de02f82451c37a2d174a73cb453d092e5b936e8 on aman-singh7:issue3234 into f7a991af12bf1cb4baefb00cfb84835c5999decb on CircuitVerse:master.

coveralls avatar Jul 13 '22 14:07 coveralls

We also need to change app/services/api/v1/group_members_controller/mails_handler.rb as we have a new variable is_mentor.

I have changed the base branch. It is there.

aman-singh7 avatar Jul 13 '22 18:07 aman-singh7

@tachyons

vedant-jain03 avatar Jul 14 '22 06:07 vedant-jain03

Code Climate has analyzed commit 51c832c9 and detected 0 issues on this pull request.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Jul 16 '22 00:07 qlty-cloud-legacy[bot]

Could you add tests as well ?

tachyons avatar Jul 19 '22 14:07 tachyons

@aman-singh7 @tachyons sorry for following up on this so late! Kindly Review!

vedant-jain03 avatar Aug 10 '22 12:08 vedant-jain03

Code Climate has analyzed commit c313509b and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 2

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Feb 03 '23 05:02 qlty-cloud-legacy[bot]