CircuitVerse icon indicating copy to clipboard operation
CircuitVerse copied to clipboard

Asking Notification permissions

Open Harshil-Jani opened this issue 3 years ago • 3 comments

Fixes #2862

Describe the changes you have made in this PR -

The main issue initially was that, It pre-assumes that either notifications are on or they are off. But for new users who just landed to their profile for very first time they need to be asked for Notification permission. This PR includes dealing with that specific case.

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Harshil-Jani avatar Feb 02 '22 06:02 Harshil-Jani

Code Climate has analyzed commit 2612b71e and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Feb 02 '22 07:02 codeclimate[bot]

Coverage Status

Coverage remained the same at 81.774% when pulling 2612b71e996abbd1a67b81a546881f81091df032 on Harshil-Jani:Harshil-Jani-patch-1 into 29f98c87dd976f9106968ec4277131127f5b9fe0 on CircuitVerse:master.

coveralls avatar Feb 02 '22 07:02 coveralls

Keeping this on hold as notification page is being revamped

tachyons avatar Jun 11 '22 14:06 tachyons