circles-core icon indicating copy to clipboard operation
circles-core copied to clipboard

Published 20 hours ago • verified publisher icon CirclesUBI

Add param (`tokenOwner`) in `checkSendLimit` method

Open llunaCreixent opened this issue 1 year ago • 1 comments

The checkSendLimit method of the core checks the sent limit of the token of the 'from' address, which is contradictory with the policy of "returning tokens to their owners". This method is only used by myxo when calculating maxFlow. I suggest we refactor the method to include the tokenOwner as param too.

llunaCreixent avatar Mar 20 '23 14:03 llunaCreixent

This issue is fixed with https://github.com/CirclesUBI/circles-core/pull/226

Problem is that will be closed when merged as production build so until then, will be blocked.

juanenrisley avatar Aug 31 '23 14:08 juanenrisley