Feat: adding support for pnpm

[ramykl]

SEMVER Update Type:

• [ ] Major
• [ ] Minor
• [ ] Patch

I would assume it is just a patch or minor as it doesn't change any of defaults or the normal behaviours, just adds an optional extra feature of pnpm as a package manager.

Description:

• add support for pnpm as a package manager
• fix test-deploy.yml node/test and node/run steps to find the correct lock files for the corresponding pkg-manager by removing the other ones

Motivation:

Closes Issues:

• https://github.com/CircleCI-Public/node-orb/issues/167
• https://github.com/CircleCI-Public/node-orb/issues/89

Also shows how someone could do this:

• https://github.com/CircleCI-Public/node-orb/issues/194

Checklist:

• [x] All new jobs, commands, executors, parameters have descriptions.
• [x] Usage Example version numbers have been updated.
• [ ] Changelog has been updated.

[ramykl]

Not sure what I need to do to get the circleCI checks to run here or if it requires a review to trigger them. I'm not sure the uninstall steps are correct for pnpm as I just took the yarn steps. I didn't see a test for those. Possibly should just be simplified to assume pnpm was installed via npm install -g pnpm.

It would be great to have a bit more documentation about contributing and how to get all the checks to run.

[ramykl]

@KyleTryon Any help on getting these final tests to run here (btw they pass on my circleCI PR to my master branch)? Or what else I can do to get this PR to be processed?

[ramykl]

Here it is against main on my fork with the checks successful and complete https://github.com/ramykl/node-orb/pull/1

[jennifer-shehane]

@KyleTryon Any chance to get a review on this? This would help with support on the cypress orb as well. https://github.com/cypress-io/circleci-orb/pull/445

[KyleTryon]

Hello all 👋 I just got back from vacation and ran your tests, all looks good! We're going to add this shortly, we just want to try to merge in some fixes before adding this feature. I'll update here shortly. Thanks again!

[ramykl]

Any updates here? @KyleTryon

[KyleTryon]

Any updates here? @KyleTryon

Sorry, I am no longer a member of CircleCI.

[ramykl]

Sorry, I am no longer a member of CircleCI.

Sorry to hear that.

[ramykl]

@brentmmarks Any chance of a review/update?

[ramykl]

@EricRibeiro any chance of a review/update? Would be great to get this merged

[EricRibeiro]

@EricRibeiro any chance of a review/update? Would be great to get this merged

I'm sorry, but I'm no longer working at CircleCI. It would be best to reach out to their support team for assistance with this pull request.

[ramykl]

@brentmmarks Any chance of a review and merge please?

[ashfaqnisar]

@felicianotech any chance you could review this ?

[CodeBooster97]

Any news?

[ramykl]

@ashfaqnisar or @felicianotech any news?

[AlvesJorge]

very thankful for your resilience @ramykl Also it's somewhat funny that the only employees from circleci to respond are the ones that are no longer employees.

Bump

[ramykl]

@marboledacci any chance of a review?

[marboledacci]

Hello @ramykl, after merging master into this, and running the tests, the PNPM tests are failing with:  ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with package.json If you can update this lock to make it work, I can merge it.

[ramykl]

Thanks @marboledacci. I have updated it now. Also, I updated the test to get the latest version of pnpm.