node-orb icon indicating copy to clipboard operation
node-orb copied to clipboard

Change `install-packages` `include-branch-in-cache-key` default to `false`

Open blimmer opened this issue 2 years ago • 1 comments

Describe Request:

Today, the cache key for install-packages includes the branch name in the cache key by default: https://github.com/CircleCI-Public/node-orb/blob/ab05d0e3718e32232bdd9c80a8ba6fac1c0bee02/src/commands/install-packages.yml#L48-L52

This causes far more cache misses than necessary, IMO, especially because the lockfile hash is already included in the key.

I propose we change the default from true to false in the next major release. This will significantly improve user experience by reducing runtimes.

blimmer avatar Oct 19 '23 16:10 blimmer

Very much agree!

ssunday avatar Nov 06 '23 19:11 ssunday