node-orb icon indicating copy to clipboard operation
node-orb copied to clipboard

Prevent nvm from falling back to building from source

Open JamesHallowell opened this issue 1 year ago • 2 comments

We've hit an issue that if the binary download fails, then nvm will fall back to building Node from source. This takes a long time and burns through credits, when it'd be quicker to just fail and try the job again.

nvm does support the -b option for installs so that it will only install from binary, and skip installing from source. It would be nice if this orb either set this option all the time, or provided some way to opt in to setting it.

Thanks!

JamesHallowell avatar Mar 20 '23 12:03 JamesHallowell

I'm tempted to set it all the time. I doubt anyone really wants to wait that long, if they did they would be far better off building their own image once.

Does anyone have any concerns? we'd probably have to make it a major change, unfortunately.

KyleTryon avatar Apr 05 '23 17:04 KyleTryon

👋 Hi! We are in the same situation, and would like not to fall back either! Registering "no concerns"!

olleolleolle avatar Apr 18 '23 11:04 olleolleolle

👋 Here to say, HOORAY!

olleolleolle avatar Aug 28 '24 15:08 olleolleolle

Version https://circleci.com/developer/orbs/orb/circleci/node?version=6.0.0 has this fixed.

marboledacci avatar Aug 28 '24 16:08 marboledacci