circleci-cli icon indicating copy to clipboard operation
circleci-cli copied to clipboard

bug: fix scheduler parameters to support bools and numbers

Open andyroyle opened this issue 2 years ago • 0 comments

Checklist

=========

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have checked for similar issues and haven't found anything relevant.
  • [x] This is not a security issue (which should be reported here: https://circleci.com/security/)
  • [x] I have read Contribution Guidelines.

Changes

=======

  • Changed type of schedule parameters from map[string]string to map[string]interface{} to enable support for bools and numbers as well as string parameters

Rationale

=========

Without this, only strings are supported via the api-client.

Considerations

==============

map[string]interface{} will transparently marshal into json without any further changes. Changing the type of the Parameters field in the Schedule struct is, unfortunately a breaking change.

andyroyle avatar Nov 15 '22 10:11 andyroyle