circleci-cli icon indicating copy to clipboard operation
circleci-cli copied to clipboard

Publishing an orb with setup: true in the example, does not include setup: true

Open imlogang opened this issue 2 years ago • 1 comments

Meta:

CircleCI CLI Version:

Operating System:

CircleCI CLI Diagnostic:


Current behavior:

When publishing an Orb with setup: true in an example on how to use a command, the example is published without setup: true.

Expected behavior:

setup: true be included in the example.

When did this begin / Was this previously working?:

First reported 9/15/22

Additional Information:

imlogang avatar Sep 15 '22 15:09 imlogang

Setup is not included in the struct: https://github.com/CircleCI-Public/circleci-cli/blob/45afa93d0ae256aded8a2c3bbd3daae8adfa8842/cmd/orb.go#L954

KyleTryon avatar Sep 15 '22 15:09 KyleTryon

@KyleTryon is adding setup to the struct the only change that might be needed? If so I'm happy to fire that PR, but not sure the steps necessary in the broader context of how do we get examples published to the orb catalog with setup: true included :)

adamdmharvey avatar Sep 30 '22 20:09 adamdmharvey

Hey, getting back to this a bit late!

Thanks for the PR @adamdmharvey, since it is merged and released, I close the issue

JulesFaucherre avatar May 17 '23 15:05 JulesFaucherre

Confirmed this now works! yay!

image

adamdmharvey avatar May 17 '23 15:05 adamdmharvey