circleci-cli icon indicating copy to clipboard operation
circleci-cli copied to clipboard

cmd: use SetIndent(2) to dump yaml subcommands

Open zchee opened this issue 3 years ago • 2 comments

Use SetIndent(2) to dump yaml subcommands.

Normally the indent for yaml is 2 indent, as does the CircleCI document.

zchee avatar Mar 18 '22 20:03 zchee

Codecov Report

Merging #677 (03eb272) into master (263902a) will increase coverage by 0.08%. The diff coverage is 69.76%.

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   27.37%   27.45%   +0.08%     
==========================================
  Files          41       41              
  Lines        4523     4509      -14     
==========================================
  Hits         1238     1238              
+ Misses       3134     3129       -5     
+ Partials      151      142       -9     
Impacted Files Coverage Δ
cmd/config.go 31.48% <16.66%> (ø)
cmd/orb.go 13.78% <27.27%> (+0.06%) :arrow_up:
cmd/admin.go 57.50% <100.00%> (+2.73%) :arrow_up:
cmd/build.go 85.71% <100.00%> (ø)
cmd/namespace.go 27.94% <100.00%> (ø)
cmd/query.go 24.32% <100.00%> (ø)
cmd/root.go 51.74% <100.00%> (ø)
cmd/setup.go 49.56% <100.00%> (+2.45%) :arrow_up:
cmd/step.go 61.90% <100.00%> (ø)
cmd/switch.go 35.71% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 263902a...03eb272. Read the comment docs.

codecov[bot] avatar Mar 18 '22 21:03 codecov[bot]

hey! thanks for you pr 😄 I don't really understand why you've commented some bunch of code, which I think does not have any link to the issue and the purpose of this PR ?

by the way, is it possible for you to rebase it ? thank you !

rlegan avatar Apr 21 '23 09:04 rlegan