Put os.Stdin size to NewReaderSize instead NewReader

[IgorHalfeld]

solves #439

In Golang NewReader, the default is 4069 for the Buffer size. What I did was use NewReaderSize to put the Buffer size as the size of os.Stdin. So it doesn't give that error of:

Error: failed to read input: bufio.Scanner: token too long

I changed ioutil.ReadAll (default size is 512) to .io.ReadFull too

[codecov[bot]]

Codecov Report

Merging #441 into master will increase coverage by 0.27%. The diff coverage is 70.37%.

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   30.89%   31.16%   +0.27%     
==========================================
  Files          26       26              
  Lines        3208     3215       +7     
==========================================
+ Hits          991     1002      +11     
+ Misses       2122     2117       -5     
- Partials       95       96       +1     

Impacted Files	Coverage Δ
cmd/context.go	30.05% <70.37%> (+5.05%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6e83e7...de18f39. Read the comment docs.

[marcomorain]

Hi @IgorHalfeld - thanks for the PR 🙏 we appreciate it.

Can you explain what the issue is here please? The issue that you have linked refers to a problem splitting test results, and this patch changes the function that reads contexts. Did you link to the wrong issue?

[IgorHalfeld]

@marcomorain I updated the PR description

[IgorHalfeld]

I fixed code coverage 🚀

IMHO I think you shouldn't use Ginkgo for testing, the Go standard test tool with Testify is the best choice for a number of factors, one of which is performance.

I used Ginkgo for 1 year and a half at work, and when we got to a large codebase we started having problems with test execution time.

[sibelius]

any plans to get this in?

it is breaking a lot of our circleci tests jobs

[sibelius]

any progress on this?

[Streeterxs]

Hope a merge soon. We have a lot of tests, fails a lot because of this

[jgcmarins]

Can we have this one merged?

[marcomorain]

I'll get someone to review this today 👍

[sibelius]

what about today?

[corinnesollows]

Merge conflicts need to be resolved. Context create was recently updated to accept OrgId

[wind57]

it seems we are hitting the same issue, and we have only? 653 tests to run, see here. Are there any plans to fix this? Or may be a workaround?

[corinnesollows]

@wind57 @IgorHalfeld This PR is conflicting with master. The quickest solution is for a fresh PR to be made by an external contributor and we can look into it from there. The longer solution is that we do have a ticket made for our team to fix this issue and when we have capacity we will look into it then. Thank you!