circleci-cli icon indicating copy to clipboard operation
circleci-cli copied to clipboard

Updated README.md, CONTRIBUTORS.md & CODE_OF_CONDUCT.md

Open antzshrek opened this issue 4 years ago • 4 comments

  • [ ] I have read Contribution Guidelines.
  • [ ] I have checked for similar issues and haven't found anything relevant.
  • [ ] This is not a security issue (which should be reported here: https://circleci.com/security/)

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from master.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

If you have any questions, feel free to ping us at @CircleCI-Public/x-team.

antzshrek avatar Apr 22 '20 17:04 antzshrek

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6f8e97e). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head 703f962 differs from pull request most recent head 23e1ba1. Consider uploading reports for the commit 23e1ba1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage        ?   30.86%           
=======================================
  Files           ?       26           
  Lines           ?     3201           
  Branches        ?        0           
=======================================
  Hits            ?      988           
  Misses          ?     2119           
  Partials        ?       94           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 22 '20 17:04 codecov[bot]

Hi @antzshrek can you explain a little bit about the change that you are proposing here please?

Thanks

marcomorain avatar Apr 23 '20 12:04 marcomorain

Hello @marcomorain the only major update I made was on CODE_OF_CONDUCT.md, unfortunately, there were some updates that I made a long time ago but didn't push it, and I don't think those updates are important aside that of CODE_OF_CONDUCT.md.

The update that I made on CODE_OF_CONDUCT.md is updating it from version 1.4 to version 2.0

Thanks

antzshrek avatar Apr 24 '20 11:04 antzshrek

Thanks @antzshrek - sorry for the delay in managing the issues on this repo. Could you rebase/clean up the commit history and commit message please, and I will merge to master.

marcomorain avatar May 18 '20 10:05 marcomorain

Hey, thanks for the PR. We updated the code of conduct to version 2.1 in this PR, so closing this one

JulesFaucherre avatar Oct 17 '23 08:10 JulesFaucherre