circleci-cli icon indicating copy to clipboard operation
circleci-cli copied to clipboard

Prefix the install path to the circleci binary

Open Miyurz opened this issue 6 years ago • 4 comments

  • [x] I have read Contribution Guidelines.
  • [x] I have checked for similar issues and haven't found anything relevant.
  • [x] This is not a security issue (which should be reported here: https://circleci.com/security/)

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from master.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

If you have any questions, feel free to ping us at @CircleCI-Public/x-team.

Miyurz avatar Jan 10 '20 09:01 Miyurz

Codecov Report

Merging #356 (1e7600c) into master (168582f) will decrease coverage by 1.91%. The diff coverage is n/a.

:exclamation: Current head 1e7600c differs from pull request most recent head 94d1b45. Consider uploading reports for the commit 94d1b45 to get more accurate results

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   32.77%   30.86%   -1.92%     
==========================================
  Files          46       26      -20     
  Lines        5415     3201    -2214     
==========================================
- Hits         1775      988     -787     
+ Misses       3387     2119    -1268     
+ Partials      253       94     -159     
Impacted Files Coverage Δ
filetree/filetree.go 73.72% <0.00%> (-4.54%) :arrow_down:
cmd/context.go 25.14% <0.00%> (-3.05%) :arrow_down:
references/references.go 60.60% <0.00%> (-3.04%) :arrow_down:
git/git.go 81.25% <0.00%> (-2.36%) :arrow_down:
cmd/update.go 23.76% <0.00%> (-0.38%) :arrow_down:
cmd/diagnostic.go 17.30% <0.00%> (-0.20%) :arrow_down:
main.go 0.00% <0.00%> (ø)
cmd/open.go 50.00% <0.00%> (ø)
cmd/check.go 0.00% <0.00%> (ø)
cmd/disabled.go 0.00% <0.00%> (ø)
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jan 10 '20 09:01 codecov[bot]

The failure isn't related to my change. It's failing in the "deploy-test" while installing the goreleaser

Miyurz avatar Jan 11 '20 03:01 Miyurz

https://github.com/CircleCI-Public/circleci-cli/pull/357/commits/c5b2cd499937bf19069ae49666c861e4bbc1eadc has a fix for the deploy-test step.

dnephin avatar Jan 13 '20 19:01 dnephin

@dnephin I am not able to re-run this build even after merging the latest of master with this change. Can you help me trigger this build ?

Miyurz avatar Jan 21 '20 04:01 Miyurz

This does not seem to pass the checks and due to the age of this PR, I will be closing it out. Feel free to make a fresh PR at any time. :)

corinnesollows avatar Aug 24 '22 19:08 corinnesollows