Prefix the install path to the circleci binary
- [x] I have read Contribution Guidelines.
- [x] I have checked for similar issues and haven't found anything relevant.
- [x] This is not a security issue (which should be reported here: https://circleci.com/security/)
Here are some helpful tips you can follow when submitting a pull request:
- Fork the repository and create your branch from
master. - Run
make buildin the repository root. - If you've fixed a bug or added code that should be tested, add tests!
- Ensure the test suite passes (
make test). - The
--debugflag is often helpful for debugging HTTP client requests and responses. - Format your code with gofmt.
- Make sure your code lints (
make lint). Note: This requires Docker to run inside a local job.
If you have any questions, feel free to ping us at @CircleCI-Public/x-team.
Codecov Report
Merging #356 (1e7600c) into master (168582f) will decrease coverage by
1.91%. The diff coverage isn/a.
:exclamation: Current head 1e7600c differs from pull request most recent head 94d1b45. Consider uploading reports for the commit 94d1b45 to get more accurate results
@@ Coverage Diff @@
## master #356 +/- ##
==========================================
- Coverage 32.77% 30.86% -1.92%
==========================================
Files 46 26 -20
Lines 5415 3201 -2214
==========================================
- Hits 1775 988 -787
+ Misses 3387 2119 -1268
+ Partials 253 94 -159
| Impacted Files | Coverage Δ | |
|---|---|---|
| filetree/filetree.go | 73.72% <0.00%> (-4.54%) |
:arrow_down: |
| cmd/context.go | 25.14% <0.00%> (-3.05%) |
:arrow_down: |
| references/references.go | 60.60% <0.00%> (-3.04%) |
:arrow_down: |
| git/git.go | 81.25% <0.00%> (-2.36%) |
:arrow_down: |
| cmd/update.go | 23.76% <0.00%> (-0.38%) |
:arrow_down: |
| cmd/diagnostic.go | 17.30% <0.00%> (-0.20%) |
:arrow_down: |
| main.go | 0.00% <0.00%> (ø) |
|
| cmd/open.go | 50.00% <0.00%> (ø) |
|
| cmd/check.go | 0.00% <0.00%> (ø) |
|
| cmd/disabled.go | 0.00% <0.00%> (ø) |
|
| ... and 37 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
The failure isn't related to my change. It's failing in the "deploy-test" while installing the goreleaser
https://github.com/CircleCI-Public/circleci-cli/pull/357/commits/c5b2cd499937bf19069ae49666c861e4bbc1eadc has a fix for the deploy-test step.
@dnephin I am not able to re-run this build even after merging the latest of master with this change. Can you help me trigger this build ?
This does not seem to pass the checks and due to the age of this PR, I will be closing it out. Feel free to make a fresh PR at any time. :)