aws-ecr-orb icon indicating copy to clipboard operation
aws-ecr-orb copied to clipboard

Published 20 hours ago • verified publisher icon CircleCI-Public

Fix env var AWS_ACCESS_KEY_ID typo

Open kangaechu opened this issue 2 years ago • 2 comments

Checklist

  • [x] All new jobs, commands, executors, parameters have descriptions
  • [x] Examples have been added for any significant new features
  • [x] README has been updated, if necessary

Motivation, issues

There are two build-and-push-image : Command and Job.

The aws-access-key-id parameter description has different comments and is inconsistent.

  • Command: AWS access key id for IAM role. Set this to the name of the environment variable you will set to hold this value, i.e. AWS_ACCESS_KEY.
  • Job: AWS access key id for IAM role. Set this to the name of the environment variable you will set to hold this value, i.e. AWS_ACCESS_KEY_ID.

In this PR, I changed AWS_ACCESS_KEY to AWS_ACCESS_KEY_ID.

related PR: https://github.com/CircleCI-Public/aws-ecr-orb/pull/96

I have checked that there is no other part that specifies AWS_ACCESS_KEY.

kangaechu avatar Jun 13 '22 03:06 kangaechu

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 12 '22 03:08 stale[bot]

@felicianotech @KyleTryon Would you review this PR?

kangaechu avatar Aug 15 '22 23:08 kangaechu

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 15 '22 22:10 stale[bot]

this pr is still alive.

kangaechu avatar Oct 16 '22 23:10 kangaechu

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/aws-ecr?version=dev:7404604c5cbd8591c7823f17fcc0db431106e55c

orb-publisher avatar Oct 19 '22 22:10 orb-publisher

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/aws-ecr?version=dev:150662d5ebc43cf8ffb181f82bc4209447cf08cb

orb-publisher avatar Oct 20 '22 19:10 orb-publisher