aws-ecr-orb icon indicating copy to clipboard operation
aws-ecr-orb copied to clipboard

Readd push-image command

Open mksplg opened this issue 2 years ago • 3 comments

What would you like to be added

Up until version 7.3, the command push-image was supported. The command pushes an already built image to ECR.

Why is this needed

We build the image using a gradle docker plugin. The reason to not use native docker build directly is, that the gradle plugin can use the build artefact from previous gradle build steps.

We only want to push the already existing image to ECR

mksplg avatar May 10 '22 09:05 mksplg

This would be useful for us as well as we build our docker images using nix. Right now we use ecr-login and then run a script to tag and push the images.

ryankbern avatar May 16 '22 21:05 ryankbern

yes please. we need to run a snyk scan on the built image before pushing it

mishabruml avatar Jun 09 '22 16:06 mishabruml

Anything prevents to continue use 7.3 until this added? Any gotchas?

liuliu avatar Aug 25 '22 18:08 liuliu

Hey Everyone,

Just wanted to let you know that I am working on the bug fixes for this orb and will add the push command back.

Thanks for everyone's contributions.

Best, Brian

brivu avatar Nov 02 '22 18:11 brivu