kotaemon icon indicating copy to clipboard operation
kotaemon copied to clipboard

fix: add langchain google dependency

Open saidmukhamad opened this issue 1 year ago • 4 comments

Description

Just added dependency in toml for langchain-google-genai

  • Fixes #328 (issue)

Type of change

  • [ ] New features (non-breaking change).
  • [x] Bug fix (non-breaking change).
  • [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected).

Checklist

  • [x] I have performed a self-review of my code.
  • [ ] I have added thorough tests if it is a core feature.
  • [ ] There is a reference to the original bug report and related work.
  • [ ] I have commented on my code, particularly in hard-to-understand areas.
  • [ ] The feature is well documented.

saidmukhamad avatar Sep 24 '24 18:09 saidmukhamad

@taprosoft

Can you look at this, please

saidmukhamad avatar Sep 26 '24 10:09 saidmukhamad

Hi @saidmukhamad sorry for the late reply. Basically it looks good. Can you revise this as well: https://github.com/Cinnamon/kotaemon/blob/79b309396bfdad33fb44dd40324667f2e4d83a26/flowsettings.py#L194

taprosoft avatar Sep 26 '24 14:09 taprosoft

Yes, no problem

saidmukhamad avatar Sep 26 '24 14:09 saidmukhamad

@taprosoft Checked and uncommented, works fine!

saidmukhamad avatar Sep 26 '24 17:09 saidmukhamad