BetterBags icon indicating copy to clipboard operation
BetterBags copied to clipboard

Caged pets should show Pet image not cage

Open woodrikj opened this issue 1 year ago • 4 comments

When you have a caged pet, adibags used to show the image of what pet it was not the cage image. Currently better bags only shows the cage. image image

woodrikj avatar Feb 19 '24 17:02 woodrikj

Additional, pet names cannot be searched for (probably because of same bug why cage is shown?)

tsracing avatar Feb 22 '24 18:02 tsracing

Battle pet will always return 'Pet Cage' for name using GetItemInfo(id) you have to get the details from the tooltip

local tooltipData = C_TooltipInfo.GetBagItem(bag, slot) -- or C_TooltipInfo.GetGuildBankItem( tab, slot )
if tooltipData then
	TooltipUtil.SurfaceArgs( tooltipData )
	if tooltipData.battlePetSpeciesID then
		-- tooltipData.battlePetSpeciesID
		-- tooltipData.battlePetLevel
		-- tooltipData.battlePetBreedQuality
		-- tooltipData.battlePetMaxHealth
		-- tooltipData.battlePetPower
		-- tooltipData.battlePetSpeed
		-- tooltipData.battlePetName
	end
end

This is a deal breaker for me.

Gil-ER avatar Feb 29 '24 20:02 Gil-ER

This is on the list of things to get done. There is a more elegant way of getting the information needed than the tooltip -- it'll get done in the near future.

Cidan avatar Feb 29 '24 20:02 Cidan

fixed in #316

zeptognome avatar Apr 11 '24 07:04 zeptognome