CRM icon indicating copy to clipboard operation
CRM copied to clipboard

Published 20 hours ago • verified publisher icon ChurchCRM

Better custom filtering

Open TiagoMRodrigues opened this issue 1 year ago • 7 comments

description

For custom fields created as drop-down, Allows people filtering by the value instead of if the custom is set

How to test the changes?

Searc for drop-down custom 1 will have one person with that selected

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

TiagoMRodrigues avatar Feb 12 '24 09:02 TiagoMRodrigues

This is the first commit where I am changing code. Previous one was just to start and set the environment. Could really use you guidance in here.

TiagoMRodrigues avatar Feb 12 '24 09:02 TiagoMRodrigues

remove the xdebug from this commit now only related with filtering by custom is in here

TiagoMRodrigues avatar Feb 14 '24 09:02 TiagoMRodrigues

Can you run PHPCS against your pull to ensure that it's matching the code style?

DAcodedBEAT avatar Feb 15 '24 00:02 DAcodedBEAT

Can you run PHPCS against your pull to ensure that it's matching the code style?

done

TiagoMRodrigues avatar Feb 15 '24 11:02 TiagoMRodrigues

@TiagoMRodrigues Can you write a Cypress End to End test for this new feature, to confirm that the code is functioning as you intended both now and later as new code gets merged in?

DAcodedBEAT avatar Feb 20 '24 15:02 DAcodedBEAT

@TiagoMRodrigues Can you write a Cypress End to End test for this new feature, to confirm that the code is functioning as you intended both now and later as new code gets merged in?

never done it can take a look this weekend.

TiagoMRodrigues avatar Feb 20 '24 16:02 TiagoMRodrigues

@TiagoMRodrigues Can you write a Cypress End to End test for this new feature, to confirm that the code is functioning as you intended both now and later as new code gets merged in?

never done it can take a look this weekend.

@DAcodedBEAT done.

TiagoMRodrigues avatar Feb 24 '24 19:02 TiagoMRodrigues

I can try to clean the test up, sorry for the delay on this - merging!

DAcodedBEAT avatar Mar 31 '24 02:03 DAcodedBEAT