CRM icon indicating copy to clipboard operation
CRM copied to clipboard

Setup page doesn't list unmet requirements

Open rsnyman opened this issue 6 years ago • 7 comments
trafficstars

The setup page does not list which requirements are not being met. Additionally, I would recommend that the Next button be disabled, rather than the current enabled but clicking just highlights the current step (with no message as to what the problem is).

image

On what page in the application did you find this issue?

Initial setup page

On what type of server is this running? Dedicated / Shared hosting? Linux / Windows?

Docker with nginx

What browser (and version) are you running?

Brave/Firefox (latest)

What version of PHP is the server running?

7.2

What version of SQL Server are you running?

Latest MariaDB Docker image

What version of ChurchCRM are you running?

3.3.2

rsnyman avatar Apr 17 '19 18:04 rsnyman

I can't reproduce this....

Starting from your https://github.com/rsnyman/churchcrm-crm/commit/05d70d3eedd7f6e49efa627fd09a2a4d07427fff, I ran

docker-compose -f docker-compose.develop.yaml build
docker-compose -f docker-compose.develop.yaml up -d

and opened my browser to http://localhost:8080; which auto-redirected to http://localhost:8080/setup

EDIT

I had uncommitted changes in my local workspace - namely the change for /setup in the NGINX default.conf file which made the auto-redirect work

    location /setup {
        try_files $uri /setup/index.php$is_args$args;
    }

crossan007 avatar Apr 17 '19 21:04 crossan007

The Next button is actually disabled until you click "I know what I'm doing", but the button is still solid blue - good pick on the UI

crossan007 avatar Apr 17 '19 21:04 crossan007

I've actually got a fix (of sorts) in my docker branch for the setup redirect. Let me make sure that it's up on GitHub.

rsnyman avatar Apr 17 '19 21:04 rsnyman

I can reproduce this issue now, having removed the location /setup option from my NGINX config.

crossan007 avatar Apr 17 '19 21:04 crossan007

BTW, you'll need to run "docker system prune" after stopping the containers in order to remove the volume so that Docker loads the new image's volume.

rsnyman avatar Apr 17 '19 21:04 rsnyman

I did docker volume prune I think it's equivalent

crossan007 avatar Apr 17 '19 21:04 crossan007

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 04 '24 02:05 github-actions[bot]

This issue was closed because it has been stalled for 15 days with no activity.

github-actions[bot] avatar Jun 30 '24 02:06 github-actions[bot]