chucker icon indicating copy to clipboard operation
chucker copied to clipboard

Add filters for transactions list

Open vbuberen opened this issue 4 years ago • 6 comments

:warning: Is your feature request related to a problem? Please describe

Currently in Chucker it is hard to find only GET items or any other items by some property (time, size, status, etc.). So it might be a good case to add filtering, especially as there are partially the same feature requests appear (for example #273).

:bulb: Describe the solution you'd like

On the main Chucker screen with list of transactions add a button which will call a BottomSheet with the following filters:

  • Checkboxes for GET, POST, PUT, etc., so users could select only one or multiple types they need.
  • Checkboxes for status codes (200, 500, etc.)
  • EditTexts with min and max request duration took.

List of filters might expand with additional users feedback on which filters they would like to see.

This BottomSheet should also be with buttons to apply and reset filters. Apply will apply filters and close the BottomSheet, while Reset should only clear filters and leave BottomSheet opened, since I see use cases for reset mainly as a sequence of clearing and selecting new filters right away.

As to search currently present on that main screen - it should do search among filtered items (e.g. on any currently visible list of transactions).

:page_facing_up: Additional context

Such feature should be implemented with minimal amount of changes to entities or other logic to not make library core more complex. Also, I would like to switch to ListAdapter with DiffUtil first to provide nice and efficient lists update.

:raising_hand: Do you want to develop this feature yourself?

  • [x] Yes
  • [ ] No

vbuberen avatar Mar 25 '20 11:03 vbuberen

That sounds like a great addition!

I think it's probably better if we find an agreement here about the list of filters we want to implement. The one you suggested sound already great.

cortinico avatar Mar 25 '20 13:03 cortinico

Few what I could think of is 1.Filter based on Http status code. 2.Filter based on Http or Https 3.Filter based on the Http request method. 4.Filter based on the duration of API call 5.Filter based on the size of the response content.

adb-shell avatar Mar 25 '20 13:03 adb-shell

I was just talking with @alorma about proposing a similar feature, and he linked me to this issue 😂

We would like to have some filtering capabilities too. In our case, filtering domains and Content-Type would be pretty handy.

Sloy avatar Apr 02 '20 10:04 Sloy

@vbuberen Can I be of any help with this one?

ArjanSM avatar Apr 10 '23 19:04 ArjanSM

@ArjanSM I think this can be implemented, but I would suggest we maybe add filtering using some custom queries? like method:GET would filter only for transactions that GET methods or so, what do you think?

cortinico avatar Apr 22 '23 19:04 cortinico

@ArjanSM I think this can be implemented, but I would suggest we maybe add filtering using some custom queries? like method:GET would filter only for transactions that GET methods or so, what do you think? @cortinico Sure! I'll start working on it.

ArjanSM avatar Apr 25 '23 22:04 ArjanSM