chucker icon indicating copy to clipboard operation
chucker copied to clipboard
verified publisher icon ChuckerTeam

Add support for select multiple request.

Open rohitjakhar opened this issue 2 years ago • 13 comments

:camera: Screenshots

:page_facing_up: Context

Issue link: Share Multiple Request at One Time

:pencil: Changes

Made change in TransactionAdapter to show color on Selected. Transaction, list of selected position, lambda for longClick on itemView. Also Add query for get selected transaction data, delete transaction data.

:hammer_and_wrench: How to test

Long press at any transaction to select transaction, after that click other transaction to select them too.

rohitjakhar avatar Nov 22 '23 07:11 rohitjakhar

@cortinico what should i do next?

rohitjakhar avatar Nov 22 '23 14:11 rohitjakhar

Thanks @cortinico for review, i will try to fix that ASAP.

rohitjakhar avatar Nov 26 '23 05:11 rohitjakhar

@rohitjakhar Just to set expectations, I'll be able to take a look at this only next week.

cortinico avatar Dec 04 '23 14:12 cortinico

@cortinico I resolve conflicts, test all corner cases.

rohitjakhar avatar Dec 16 '23 09:12 rohitjakhar

@rohitjakhar sorry I've been off for XMas vacation and haven't had time to look at this again. I can look into it this week so we can merge it. Could you fix the detekt/ktlint failures in the meanwhile?

cortinico avatar Jan 08 '24 14:01 cortinico

We're getting close to a mergeabble state :)

cortinico avatar Jan 14 '24 00:01 cortinico

@cortinico I fix above issues.

rohitjakhar avatar Feb 01 '24 11:02 rohitjakhar

@cortinico can you give me next step to merge it?

rohitjakhar avatar Mar 27 '24 12:03 rohitjakhar

@cortinico I just update code and run ktlintformat.

rohitjakhar avatar Jun 06 '24 14:06 rohitjakhar

@cortinico should i supress TooManyFunctions ?

rohitjakhar avatar Jun 06 '24 16:06 rohitjakhar

@cortinico should i supress TooManyFunctions ?

Yes please do, it's reasonable to do so in MainActivity.kt

cortinico avatar Jun 07 '24 09:06 cortinico

@cortinico All are green

rohitjakhar avatar Jun 13 '24 14:06 rohitjakhar

@rohitjakhar thanks for following up.

Sadly there are still a couple of bugs:

  1. The 4xx transactions are rendered impossible to read (see screnshot). We should probably change the text color to black when things are selected.

Screenshot_1718923015

  1. If you quickly select transactions as they're getting populated, you end up in a broken state where not all selected transactions are actually deleted. See video:

https://github.com/ChuckerTeam/chucker/assets/3001957/36f5c85b-c2b8-4f54-ac05-1a4468dd8f61

Can I ask you to look into those 2 problems and then we can merge it 👍

cortinico avatar Jun 20 '24 22:06 cortinico