manjaro-architect icon indicating copy to clipboard operation
manjaro-architect copied to clipboard

Published 20 hours ago • verified publisher icon Chrysostomus

Check_requirements() is slow

Open Chrysostomus opened this issue 8 years ago • 3 comments

The function has several pointless sleep clauses. Idea:

  1. if not root, ask for password instead of failing, like manjaro-chroot does
  2. Do not notify that all checks were passed. Only notify if something is missing.

Chrysostomus avatar May 17 '17 09:05 Chrysostomus

Also, locale generation seems to take a long time. We should somehow check if locales have already been generated.

Chrysostomus avatar May 17 '17 11:05 Chrysostomus

Or, maybe just send it to backgound with &?

#DIALOG " $_Config " --infobox "\n$_ApplySet\n " 0 0
sed -i "s/#${CURR_LOCALE}/${CURR_LOCALE}/" /etc/locale.gen
locale-gen >/dev/null 2>$ERR &

Is there a reason why we need to wait for it to finish? $LANG is generated directly from user choice anyway

Chrysostomus avatar May 17 '17 11:05 Chrysostomus

It seems not to be that simple...

Chrysostomus avatar May 17 '17 17:05 Chrysostomus