hibernator icon indicating copy to clipboard operation
hibernator copied to clipboard

2 Problems

Open IgorVian opened this issue 8 years ago • 12 comments

Using your very useful script in Manjaro, caused 2 problems:

  1. grub file modified like this: GRUB_CMDLINE_LINUX_DEFAULT="quiet splash $(resume_boot_option)" instead of: GRUB_CMDLINE_LINUX_DEFAULT="quiet splash resume=UUID=c5c38daf-e419-4f32-9b94-e1e7edb9f87d resume_offset=1677312"
  2. in mkinitcpio.conf not inserted the "resume" word

I attached the original files, so you can test. Files.zip

IgorVian avatar Apr 17 '16 15:04 IgorVian

Okay, #1 should be easy to troubleshoot, since it seems to be a case of variable not being expanded.

I'll look into these.

Chrysostomus avatar Apr 17 '16 15:04 Chrysostomus

Well, I found a boatload of other problems as well. I think this going to be a rewrite...

Chrysostomus avatar Apr 17 '16 16:04 Chrysostomus

Okay, I think I found the problem with #2...

Chrysostomus avatar Apr 17 '16 16:04 Chrysostomus

Okay, found the cure and fixed a whole lot of other problems. Will be updating soon. Thanks again for this immensely useful bug report!

Chrysostomus avatar Apr 17 '16 16:04 Chrysostomus

Okay, going to get somw sleep. Cannot upload changes yet, because I noticed that grub requires more complex logic for determining the right resume option, depending on whether device mapper names or uuid or partuuid is used.

Chrysostomus avatar Apr 17 '16 17:04 Chrysostomus

Thanks for your quickly reply. I'm eager to see the changes!

IgorVian avatar Apr 23 '16 16:04 IgorVian

Okay, I made some changes that should theoretically fix the issue with grub. Can you test it if it works for you?

Chrysostomus avatar Apr 25 '16 23:04 Chrysostomus

Okay, I did some testing and the problem is not yet solved. The sed command that should insert kernel parameters into /etc/default/grub is somehow faulty.

Chrysostomus avatar Apr 26 '16 00:04 Chrysostomus

Okay, I checked again. It works unless there is additional space at the end of kernel parameter line in /etc/default/grub.

Chrysostomus avatar Apr 26 '16 01:04 Chrysostomus

Should be fixed now

Chrysostomus avatar Apr 26 '16 07:04 Chrysostomus

I tried to run this script today but the GRUB_CMDLINE_LINUX_DEFAULT line edit does not work anymore.

Instead of the partition UUID only a whitespace is appended to that line. Could it be a variable expansion problem as already happened?

Here you can find a bash -x log of the script execution: hibernator.log

ohquero avatar Feb 28 '19 06:02 ohquero

Thanks, I'll look into it.

Chrysostomus avatar Feb 28 '19 08:02 Chrysostomus