hibernator
hibernator copied to clipboard
2 Problems
Using your very useful script in Manjaro, caused 2 problems:
- grub file modified like this: GRUB_CMDLINE_LINUX_DEFAULT="quiet splash $(resume_boot_option)" instead of: GRUB_CMDLINE_LINUX_DEFAULT="quiet splash resume=UUID=c5c38daf-e419-4f32-9b94-e1e7edb9f87d resume_offset=1677312"
- in mkinitcpio.conf not inserted the "resume" word
I attached the original files, so you can test. Files.zip
Okay, #1 should be easy to troubleshoot, since it seems to be a case of variable not being expanded.
I'll look into these.
Well, I found a boatload of other problems as well. I think this going to be a rewrite...
Okay, I think I found the problem with #2...
Okay, found the cure and fixed a whole lot of other problems. Will be updating soon. Thanks again for this immensely useful bug report!
Okay, going to get somw sleep. Cannot upload changes yet, because I noticed that grub requires more complex logic for determining the right resume option, depending on whether device mapper names or uuid or partuuid is used.
Thanks for your quickly reply. I'm eager to see the changes!
Okay, I made some changes that should theoretically fix the issue with grub. Can you test it if it works for you?
Okay, I did some testing and the problem is not yet solved. The sed command that should insert kernel parameters into /etc/default/grub is somehow faulty.
Okay, I checked again. It works unless there is additional space at the end of kernel parameter line in /etc/default/grub.
Should be fixed now
I tried to run this script today but the GRUB_CMDLINE_LINUX_DEFAULT line edit does not work anymore.
Instead of the partition UUID only a whitespace is appended to that line. Could it be a variable expansion problem as already happened?
Here you can find a bash -x
log of the script execution: hibernator.log
Thanks, I'll look into it.