Homebrew-Details icon indicating copy to clipboard operation
Homebrew-Details copied to clipboard

Cannot compile

Open Hwilliams8548 opened this issue 3 years ago • 12 comments

Describe the bug Whenever I try to compile I get a "features_cpu.h" error. I looked all over the internet and all I saw was "features_cpu.c" To Reproduce

  1. Download the source code
  2. Try to compile it
  3. See error

Expected behavior I expected for it to successfully compile :

Hwilliams8548 avatar Nov 10 '21 02:11 Hwilliams8548

Can you explain more? Just saying "there's an error" doesn't help at all.

EmmmaTech avatar Nov 10 '21 04:11 EmmmaTech

Can you explain more? Just saying "there's an error" doesn't help at all.

C:/Users/username/Desktop/Homebrew-Details-1.05/include/borealis/repeating_task.hpp:22:10: fatal error: libretro-common/features/features_cpu.h: No such file or directory 22 | #include <libretro-common/features/features_cpu.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.

I cannot find this file anywhere

Hwilliams8548 avatar Nov 10 '21 22:11 Hwilliams8548

Apologies for the confusion! I knew what you meant. features_cpu.h is part of borealis's copy of libretro-common, which for this project is in: homebrew-details/library/include/borealis/extern/libretro-common/features/features_cpu.h

Sorry, I know it's not super obvious yet because I never got around to writing out the How to Compile section. I have the library folder symlinked to the version of borealis I use. Until I make this a prettier fix (like a subrepo), you can use this zip I just made to replace the folder structure on your machine: library.zip

Chrscool8 avatar Nov 10 '21 22:11 Chrscool8

That is messed up. Most people who use Borealis at least clone Borealis as a submodule/subrepo so it's available on their repo. Making it so people have to download the library manually is not a good idea. I would recommend making this change now before anyone fails to compile again.

EmmmaTech avatar Nov 11 '21 00:11 EmmmaTech

Lol I know. It's this: https://github.com/Chrscool8/borealis

I was just trying to give a quick solution until I got it set up. Why are you answering people on my repo's issues as if you're a contributor to my personal project lol.

Chrscool8 avatar Nov 11 '21 00:11 Chrscool8

Why are you answering people on my repo's issues as if you're a contributor to my personal project lol.

Sorry! Just a common habit to act as a contributor.

EmmmaTech avatar Nov 11 '21 00:11 EmmmaTech

@Hwilliams8548 I'm finding there's other links like this in the project. I'll let you know once I revise all these and make it more self-contained.

Chrscool8 avatar Nov 11 '21 03:11 Chrscool8

I added a few dependencies as subtrees in the project (or at least I tried to). If it went correctly, everything should now either be included in this latest commit or in the devkitpro pacman installer.

Chrscool8 avatar Nov 11 '21 05:11 Chrscool8

I have successfully compiled it now, thanks!

Hwilliams8548 avatar Nov 11 '21 23:11 Hwilliams8548

Happy to hear that! Do you have any projects in mind to use it for?

Chrscool8 avatar Nov 12 '21 02:11 Chrscool8

Happy to hear that! Do you have any projects in mind to use it for?

Not really but I do want to know something. How do I make it use a different config by default. For example: If I wanted to add more to the blacklist inside of the default config

Hwilliams8548 avatar Nov 12 '21 03:11 Hwilliams8548

Sure thing. For that example, you can find where it initializes it right here: https://github.com/Chrscool8/Homebrew-Details/blob/548ee80a92f9af2bf83435f753ba77353ea48be6/src/utils/blacklist.cpp#L30

(I really should have/thought I did have an init function, but I guess not.)

You can add more lines just like that and when it creates the file for the first time (or after deleting it), it'll add them in.

I'm pretty sure those, like most settings, are simply base64 encoded (and decoded) line by line when written to the files, so you can add and remove lines manually too using a website or whatever you like to do so.

Chrscool8 avatar Nov 14 '21 03:11 Chrscool8