snapraid-runner adding slack and pushbullet

adding slack and pushbullet

Open bjay1404 opened this issue 7 years ago • 2 comments

I added slack and pushbullet

Jul 12 '17 23:07 bjay1404

Thoughts on the code?

Jul 31 '17 01:07 bjay1404

Hey, sry for not responding sooner – I didn't yet find time to go over the whole PR.

At a quick glance there seem to be some issues with it:

How does this handle the fact that existing config files don't have a pushbullet and slack config?
The comments in the config file don't seem correct
What does the title config in the slack section do?
Why did you rename the default config file name?
Won't this crash for everybody who doesn't have the slackclient python package installed?

Jul 31 '17 05:07 Chronial